add test for undefined required prop

mobxjs · Sep 26, 2019 · e717291 · e717291
1 parent 3614a64
commit e717291
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/src/core/serialize.js b/src/core/serialize.js
@@ -59,7 +59,6 @@ export function serializeWithSchema(schema, obj) {
         if (propDef === false)
             return
         var jsonValue = propDef.serializer(obj[key], key, obj)
-        console.warn({schema, obj, key, value: obj[key], jsonValue})
         if (jsonValue === SKIP){
             return
         }

diff --git a/test/simple.js b/test/simple.js
@@ -39,11 +39,12 @@ test("it should serialize simple object", t1 => {
         t.end()
     })
 
-    test("it should (de)serialize all fields in the schema even if they're not defined on the object (existing behavior)", t => {
+    test("it should serialize all fields in the schema even if they're not defined on the object (existing behavior)", t => {
         var a = { y: 1337 }
         var s = serialize(schema, a)
 
         t.deepEqual(s, { x: undefined })
+        // Note that this behavior is only one-way: it doesn't set props as undefined on the deserialized object.
         t.deepEqual(deserialize(schema, s), {})
 
         var d = { x: 1 }
@@ -162,26 +163,28 @@ test("it should not serialize values for optional properties", t => {
     var schema = {
         factory: () => ({}),
         props: {
-            x: optional(primitive())
+            optionalProp: optional(primitive()),
+            requiredProp: primitive()
         }
     }
     var a = { y: 1337 }
     var s = serialize(schema, a)
 
-    t.deepEqual(s, {})
+    t.deepEqual(s, {requiredProp: undefined})
+    // Note that this behavior is only one-way: it doesn't set props as undefined on the deserialized object.
     t.deepEqual(deserialize(schema, s), {})
 
-    var d = { x: 1 }
+    var d = { optionalProp: 1 }
     update(schema, a, d)
     t.deepEqual(a, {
-        y: 1337, x: 1
+        y: 1337, optionalProp: 1
     })
 
     test("it should skip missing attrs", t3 => {
         update(schema, a, {}, (err, res) => {
             t3.ok(res === a)
             t3.notOk(err)
-            t3.equal(res.x, 1)
+            t3.equal(res.optionalProp, 1)
             t3.end()
         })
     })