fix(input): remove fixed height of label container (geist-org#727)

* fix(input): remove fixed height of label container * test: update snapshots for height changes Co-authored-by: zexun.liu <[email protected]> Co-authored-by: unix <[email protected]>
mochi-sann · Feb 12, 2022 · d2fc8d9 · d2fc8d9
1 parent c8a0d64
commit d2fc8d9
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 18 deletions.
diff --git a/components/auto-complete/__tests__/__snapshots__/search.test.tsx.snap b/components/auto-complete/__tests__/__snapshots__/search.test.tsx.snap
@@ -81,7 +81,6 @@ LoadedCheerio {
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }
@@ -208,7 +207,6 @@ LoadedCheerio {
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }
@@ -524,7 +522,6 @@ LoadedCheerio {
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }
@@ -651,7 +648,6 @@ LoadedCheerio {
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }
@@ -1030,7 +1026,6 @@ LoadedCheerio {
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }
@@ -1157,7 +1152,6 @@ LoadedCheerio {
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }
@@ -1473,7 +1467,6 @@ LoadedCheerio {
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }
@@ -1600,7 +1593,6 @@ LoadedCheerio {
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }

diff --git a/components/input/__tests__/__snapshots__/index.test.tsx.snap b/components/input/__tests__/__snapshots__/index.test.tsx.snap
@@ -30,7 +30,6 @@ exports[`Input should be work with icon 1`] = `
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }
@@ -148,7 +147,6 @@ exports[`Input should be work with icon 1`] = `
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }
@@ -277,7 +275,6 @@ exports[`Input should be work with label 1`] = `
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }
@@ -402,7 +399,6 @@ exports[`Input should be work with label 1`] = `
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }
@@ -517,7 +513,6 @@ exports[`Input should be work with label 1`] = `
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }
@@ -618,7 +613,6 @@ exports[`Input should work with different status 1`] = `
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }
@@ -715,7 +709,6 @@ exports[`Input should work with different status 1`] = `
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }
@@ -812,7 +805,6 @@ exports[`Input should work with different status 1`] = `
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }

diff --git a/components/input/__tests__/__snapshots__/password.test.tsx.snap b/components/input/__tests__/__snapshots__/password.test.tsx.snap
@@ -30,7 +30,6 @@ exports[`InputPassword should render correctly 1`] = `
             --input-height: calc(2.25 * 16px);
             font-size: calc(0.875 * 16px);
             width: initial;
-            height: var(--input-height);
             padding: 0 0 0 0;
             margin: 0 0 0 0;
           }

diff --git a/components/input/input.tsx b/components/input/input.tsx
@@ -166,7 +166,6 @@ const InputComponent = React.forwardRef<
             --input-height: ${SCALES.height(2.25)};
             font-size: ${SCALES.font(0.875)};
             width: ${SCALES.width(1, 'initial')};
-            height: var(--input-height);
             padding: ${SCALES.pt(0)} ${SCALES.pr(0)} ${SCALES.pb(0)} ${SCALES.pl(0)};
             margin: ${SCALES.mt(0)} ${SCALES.mr(0)} ${SCALES.mb(0)} ${SCALES.ml(0)};
           }