Skip to content

Fix async resource functions not being awaited #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/mcp/server/fastmcp/resources/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,12 @@ class FunctionResource(Resource):
async def read(self) -> str | bytes:
"""Read the resource by calling the wrapped function."""
try:
result = await self.fn() if inspect.iscoroutinefunction(self.fn) else self.fn()
# Call the function first to see if it returns a coroutine
result = self.fn()
# If it's a coroutine, await it
if inspect.iscoroutine(result):
result = await result

if isinstance(result, Resource):
return await result.read()
elif isinstance(result, bytes):
Expand Down
42 changes: 41 additions & 1 deletion tests/issues/test_188_concurrency.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import anyio
import pytest
from pydantic import AnyUrl

from mcp.server.fastmcp import FastMCP
from mcp.shared.memory import create_connected_server_and_client_session as create_session


@pytest.mark.anyio
async def test_messages_are_executed_concurrently():
async def test_messages_are_executed_concurrently_tools():
server = FastMCP("test")
event = anyio.Event()
tool_started = anyio.Event()
Expand Down Expand Up @@ -44,3 +45,42 @@ async def trigger():
"trigger_end",
"tool_end",
], f"Expected concurrent execution, but got: {call_order}"


@pytest.mark.anyio
async def test_messages_are_executed_concurrently_tools_and_resources():
server = FastMCP("test")
event = anyio.Event()
tool_started = anyio.Event()
call_order = []

@server.tool("sleep")
async def sleep_tool():
call_order.append("waiting_for_event")
tool_started.set()
await event.wait()
call_order.append("tool_end")
return "done"

@server.resource("slow://slow_resource")
async def slow_resource():
# Wait for tool to start before setting the event
await tool_started.wait()
event.set()
call_order.append("resource_end")
return "slow"

async with create_session(server._mcp_server) as client_session:
# First tool will wait on event, second will set it
async with anyio.create_task_group() as tg:
# Start the tool first (it will wait on event)
tg.start_soon(client_session.call_tool, "sleep")
# Then the resource (it will set the event)
tg.start_soon(client_session.read_resource, AnyUrl("slow://slow_resource"))

# Verify that both ran concurrently
assert call_order == [
"waiting_for_event",
"resource_end",
"tool_end",
], f"Expected concurrent execution, but got: {call_order}"
Loading