Skip to content

fix: Expose completions capability #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fredericbarthelet
Copy link
Contributor

Advertising support for completions in servers where a completion handler has been defined.
Similar to modelcontextprotocol/typescript-sdk#546

Motivation and Context

While implementing modelcontextprotocol/inspector#441, I found out that the only way to advertise completions support was defining it manually in constructor argument.

How Has This Been Tested?

Added corresponding unit tests.

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Kludex
Kludex previously approved these changes Jul 7, 2025
@fredericbarthelet fredericbarthelet force-pushed the expose-completions-capability branch from 720a235 to 0dfa343 Compare July 7, 2025 07:12
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@ihrpr ihrpr merged commit 906ceea into modelcontextprotocol:main Jul 7, 2025
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants