Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional inner system view connector coordinates #33

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

peter-lobner
Copy link
Contributor

@peter-lobner peter-lobner commented Apr 26, 2024

A pragmatic minor change as discussed with @klausschuch to support optional connectors for the system inner view to enable to preserve the inside system layout when integrating a system in a system structure and to avoid unintended changes to the position of the connectors on the inside view of the system when doing layout changes on the outside view and vice versa.

@peter-lobner
Copy link
Contributor Author

Also this is my proposal to resolve modelica/ssp-standard-dev#138

@peter-lobner peter-lobner marked this pull request as ready for review April 26, 2024 11:28
@JochenKoehler
Copy link
Collaborator

Web meeting 2024-04-26

  • Some remarks from Pierre regarding "cosmetic changes". Will do the changes accordingly
  • Dag is asking if his topic regarding rotating of connectors was taken into account. This is not the case. Dag will handle this eventually with a separate pull request (maybe for a next release)

Copy link
Collaborator

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight rewriting for clarity and grammar.

docs/5___ssd.adoc Outdated Show resolved Hide resolved
schema/SystemStructureDescription.xsd Outdated Show resolved Hide resolved
schema/SystemStructureDescription11.xsd Outdated Show resolved Hide resolved
Copy link
Contributor

@DagBruck DagBruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If inner and outer coordinates are different, a "transparent" view shall use the outer view's coordinates.

@JochenKoehler
Copy link
Collaborator

web meeting 2024-05-08: Klaus will have a final look at it and add some review comments for final merge

docs/5___ssd.adoc Outdated Show resolved Hide resolved
@pmai pmai added this to the 2.0-alpha.1 milestone Jul 5, 2024
Copy link
Collaborator

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCB 2024-09-13: Can be merged once all the occurrences of special coordinate system are changed to connector coordinate system.

docs/5___ssd.adoc Outdated Show resolved Hide resolved
docs/5___ssd.adoc Outdated Show resolved Hide resolved
docs/5___ssd.adoc Outdated Show resolved Hide resolved
schema/SystemStructureDescription.xsd Outdated Show resolved Hide resolved
schema/SystemStructureDescription11.xsd Outdated Show resolved Hide resolved
@pmai pmai force-pushed the feature/optional-system-inner-connector-coordinates branch from cf756b3 to ce76e35 Compare September 13, 2024 14:11
@pmai pmai merged commit 1707986 into main Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants