Use fully-qualified classname in conditional

Change made by request for better maintainability.

core/src/Revolution/Processors/Element/Create.php

@@ -15,6 +15,7 @@
 use MODX\Revolution\modElement;
 use MODX\Revolution\Processors\Model\CreateProcessor;
 use MODX\Revolution\modTemplate;
+use MODX\Revolution\modTemplateVar;
 use MODX\Revolution\Validation\modValidator;
 
 /**
@@ -61,9 +62,9 @@
         $locked = (bool)$this->getProperty('locked', false);
         $this->object->set('locked', $locked);
 
-        $elementClassName = array_pop(explode('\\', $this->classKey));
+        $isTV = $this->classKey === modTemplateVar::class;
 
-        if ($elementClassName === 'modTemplateVar') {
+        if ($isTV) {
             if ($caption = trim($this->getProperty('caption', ''))) {
                 $caption = $this->modx->stripHtml(
                     $caption,
@@ -75,12 +76,12 @@
         }
 
         if ($description = trim($this->getProperty('description', ''))) {
-            $description = $elementClassName === 'modTemplateVar'
+            $description = $isTV
                 ? $this->modx->stripHtml(
                     $description,
                     $this->modx->getOption('elements_description_allowedtags'),
                     $this->modx->getOption('elements_description_allowedattr')
                 )
                 : strip_tags($description)
                 ;
             $this->object->set('description', $description);

core/src/Revolution/Processors/Element/Update.php

@@ -15,6 +15,7 @@
 use MODX\Revolution\modElement;
 use MODX\Revolution\Processors\Model\UpdateProcessor;
 use MODX\Revolution\modTemplate;
+use MODX\Revolution\modTemplateVar;
 
 /**
  * Abstract class for Update Element processors. To be extended for each derivative element type.
@@ -34,7 +35,7 @@
     public function initialize()
     {
         if ($this->classKey === modTemplate::class) {
             $this->elementNameField = 'templatename';
         }
         return parent::initialize();
     }
@@ -56,26 +57,26 @@
             $this->object->set('locked', (bool)$locked);
         }
 
-        $elementClassName = array_pop(explode('\\', $this->classKey));
+        $isTV = $this->classKey === modTemplateVar::class;
 
-        if ($elementClassName === 'modTemplateVar') {
+        if ($isTV) {
             if ($caption = trim($this->getProperty('caption', ''))) {
                 $caption = $this->modx->stripHtml(
                     $caption,
                     $this->modx->getOption('elements_caption_allowedtags'),
                     $this->modx->getOption('elements_caption_allowedattr')
                 );
                 $this->object->set('caption', $caption);
             }
         }
 
         if ($description = trim($this->getProperty('description', ''))) {
-            $description = $elementClassName === 'modTemplateVar'
+            $description = $isTV
                 ? $this->modx->stripHtml(
                     $description,
                     $this->modx->getOption('elements_description_allowedtags'),
                     $this->modx->getOption('elements_description_allowedattr')
                 )
                 : strip_tags($description)
                 ;
             $this->object->set('description', $description);
@@ -86,13 +87,13 @@
         $name = $this->getProperty($this->elementNameField, '');
 
         if (empty($name)) {
             $this->addFieldError($this->elementNameField, $this->modx->lexicon($this->objectType . '_err_ns_name'));
         } else {
             if ($this->alreadyExists($name)) {
                 $this->addFieldError(
                     $this->elementNameField,
                     $this->modx->lexicon($this->objectType . '_err_ae', ['name' => $name])
                 );
             }
         }
 
@@ -110,7 +111,7 @@
         if ($this->object->staticContentChanged()) {
             if (!$this->object->isStaticSourceMutable()) {
                 $this->addFieldError('static_file', $this->modx->lexicon('element_static_source_immutable'));
             } else if (!$this->object->isStaticSourceValidPath()) {
                 $this->addFieldError('static_file', $this->modx->lexicon('element_static_source_protected_invalid'));
             }
         }
@@ -135,13 +136,13 @@
 
     public function cleanup()
     {
         $fields = ['id', $this->elementNameField, 'description', 'locked', 'category', 'content'];
         return $this->success(
             '',
             array_merge(
                 $this->object->get($fields),
                 ['previous_category' => $this->previousCategory]
             )
         );
     }
 }