Skip to content

Commit

Permalink
pw_build_info: Don't silence warning via builds
Browse files Browse the repository at this point in the history
Since the warnings that pw_build_info needs to silence are handled
inside the source files, there's now no need for the warnings to be
silenced via compiler flags (which was brittle anyway).

Change-Id: I8fed2c4578b2fe51f3d0e4b73527b1404370814c
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/103801
Commit-Queue: Armando Montanez <[email protected]>
Reviewed-by: Ewout van Bekkum <[email protected]>
  • Loading branch information
armandomontanez authored and CQ Bot Account committed Jul 28, 2022
1 parent eb00223 commit cce5b1d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
4 changes: 0 additions & 4 deletions pw_build_info/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ if (current_os != "mac" && current_os != "win") {
":linker_script",
]
public_configs = [ ":public_include_path" ]
cflags = [
"-Wno-array-bounds",
"-Wno-stringop-overflow",
]
public = [ "public/pw_build_info/build_id.h" ]
sources = [ "build_id.cc" ]
deps = [
Expand Down
3 changes: 0 additions & 3 deletions pw_build_info/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ if((NOT "${CMAKE_SYSTEM_NAME}" STREQUAL "Windows") AND
build_id.cc
PRIVATE_DEPS
pw_preprocessor
PRIVATE_COMPILE_OPTIONS
-Wno-array-bounds
-Wno-stringop-overflow
)
endif()

Expand Down

0 comments on commit cce5b1d

Please sign in to comment.