fix slow hasFileType check

Closes hapi-swagger#484
mondia · Sep 19, 2018 · 1f8a812 · 1f8a812
1 parent c38af0a
commit 1f8a812
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/lib/paths.js b/lib/paths.js
@@ -1,6 +1,5 @@
 const Hoek = require('hoek');
 const Joi = require('joi');
-const fastSafeStringify = require('fast-safe-stringify');
 
 const Parameters = require('../lib/parameters');
 const Definitions = require('../lib/definitions');
@@ -386,8 +385,10 @@ internals.overload = function (base, priority) {
  * @return {Boolean}
  */
 internals.hasFileType = function (route) {
-
-    let routeString = fastSafeStringify(route);
+    const routeString = JSON.stringify(route, (key, value) => {
+        // _currentJoi is a circular reference, introduced in Joi v11.0.0
+        return key === '_currentJoi' ? undefined : value;
+    });
     return routeString.indexOf('swaggerType') > -1;
 };
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -21,7 +21,6 @@
   },
   "dependencies": {
     "boom": "^7.1.1",
-    "fast-safe-stringify": "^1.2.3",
     "handlebars": "^4.0.11",
     "hoek": "^5.0.3",
     "http-status": "^1.0.1",