-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: msys2: pin boost to 1.86.0 #9623
Conversation
tobtoht
commented
Dec 16, 2024
- Boost >= 1.87.0 breaks builds (Add support for upcoming Boost 1.87.0 (Boost.Asio removals) #9596)
- MSYS2 ships Boost 1.87.0
- Temporary downgrade to get CI to pass until a proper fix is in place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put an integrity check here please? Perhaps just a sha256sum
or a PGP verify or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ueh
Using sha256 hash verification instead of gpg, as the latter would allow an attacker that has access to the msys2 repo to trick us into installing any signed package. Assuming the release signing key isn't compromised (in which case everything is compromised), this would effectively allow an attacker to cause an older version of Boost to be installed while still passing CI. The older version of Boost could have a vulnerability that is not present in 1.86.0, and someone could unwittingly decide to run this development build outside of a testing environment. I'm also downgrading Edit: Assuming the attacker has kept older copies of the Edit2: In fact, database signatures are optional by default (and msys2 does not configure it otherwise). If a signature is not present, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files built don't get uploaded anyway so I don't think there is a legitimate attack vector here
Ah right, it's the depends build that gets uploaded as an artifact, not this one. So yeah, the purpose of this job is only to check if Monero successfully builds on msys2. |