Skip to content

chore: move --readOnly to env var #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

chore: move --readOnly to env var #350

merged 1 commit into from
Jul 9, 2025

Conversation

nirinchev
Copy link
Collaborator

Proposed changes

Didn't notice #347 was set to auto-merge prior to approving.

Checklist

@Copilot Copilot AI review requested due to automatic review settings July 9, 2025 17:49
@nirinchev nirinchev requested a review from a team as a code owner July 9, 2025 17:49
@nirinchev nirinchev requested review from blva and removed request for a team July 9, 2025 17:49
Copilot
Copilot AI reviewed Jul 9, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Docker invocation in the README to replace the --readOnly CLI flag with an equivalent environment variable.

  • Replace --readOnly with -e MDB_MCP_READ_ONLY="true"
  • Remove the inline flag from the image invocation
Comments suppressed due to low confidence (1)

README.md:156

  • Add a brief note above this snippet explaining what MDB_MCP_READ_ONLY does and what values it accepts, so readers understand its effect without referring to code.
  -e MDB_MCP_READ_ONLY="true" \

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 16176516695

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 76.034%
Totals Coverage Status
Change from base Build 16176445907: 0.4%
Covered Lines: 847
Relevant Lines: 1030
💛 - Coveralls

blva
blva approved these changes Jul 9, 2025
View reviewed changes
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@nirinchev nirinchev merged commit 2456bfd into main Jul 9, 2025
18 checks passed
@nirinchev nirinchev deleted the ni/readonly branch July 9, 2025 18:44
nirinchev added a commit that referenced this pull request Jul 10, 2025
@nirinchev
Merge branch 'main' into ni/connect-guidance
04a3a00 
* main:
  chore: bump dependencies (#346)
  chore: fix cursor link (#351)
  chore: move --readOnly to env var (#350)
  chore: default examples with --readOnly (#347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@blva blva blva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nirinchev @coveralls @blva