chore: update required node to >=20.19.0 #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mongodb-js/oidc-plugin requires openid-client (a universal ESM module) using `require()` in the dist. CJS style require for universal ESMs are supported by default in node ^20.19.0 || ^22.12.0 || >=23.0.0. Ref: https://www.npmjs.com/package/openid-client#fn-universal For that reason it would be better to hint that we work best with at-least 20.19.0 instead of what we have currently.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the minimum Node.js engine version to 20.19.0 to ensure compatibility with using require() for universal ESM modules like openid-client.
- Bump Node.js engine requirement from
>=20.10.0to>=20.19.0
Comments suppressed due to low confidence (1)
package.json:81
- [nitpick] Consider updating the project README or other user-facing documentation to mention the new minimum Node.js requirement (>=20.19.0).
"node": ">=20.19.0"
Pull Request Test Coverage Report for Build 16203278003Details
💛 - Coveralls |
fmenezes
approved these changes
Jul 10, 2025
blva
reviewed
Jul 10, 2025
| @@ -78,6 +78,6 @@ | |||
| "zod": "^3.25.76" | |||
| }, | |||
| "engines": { | |||
| "node": ">=20.10.0" | |||
| "node": ">=20.19.0" | |||
There was a problem hiding this comment.
can we also update the readme and open a docs ticket to update the requirement? thanks!
There was a problem hiding this comment.
Thanks for pointing that out, missed it. Just updated it in my last commit. Will open a docs ticket as well as soon as I merge it.
There was a problem hiding this comment.
Here's the docs update ticket.
nirinchev
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
@mongodb-js/oidc-plugin requires openid-client (a universal ESM module) using
require()in the dist. CJS style require for universal ESMs are supported by default in node ^20.19.0 || ^22.12.0 || >=23.0.0.Ref: https://www.npmjs.com/package/openid-client#fn-universal
For that reason it would be better to hint that we work best with at-least 20.19.0 instead of what we have currently.
Related to #348
Checklist