Do not depend on rspec meta gem
#222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
|
Seems reasonable if you can fix the build ;) |
lucasmazza
force-pushed
the
rspec-meta-dependency
branch
from
f61ab18 to
6f9766c
Compare
The `rspec` gem is a shortcut to depend on `rspec-core`, `rspec-expectations` and `rspec-mocks`, but depending on it directly clashes with the `rspec-rails` gem that is also a bag of sub RSpec dependencies. This helps with scenarios where one meta gem locks the update of another one, like in the following: ``` bundle update rspec-rails Fetching gem metadata from https://rubygems.org/....... Fetching gem metadata from https://rubygems.org/. Resolving dependencies....... Bundler could not find compatible versions for gem "rspec-mocks": In Gemfile: mongoid-rspec was resolved to 4.0.1, which depends on rspec (~> 3.3) was resolved to 3.7.0, which depends on rspec-mocks (~> 3.7.0) rspec-rails (= 3.8.0) was resolved to 3.8.0, which depends on rspec-mocks (~> 3.8.0) ```
lucasmazza
force-pushed
the
rspec-meta-dependency
branch
from
6f9766c to
b7d730b
Compare
|
@dblock all green now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rspecgem is a shortcut to depend onrspec-core,rspec-expectationsandrspec-mocks, but depending on it directly clashes with therspec-railsgem that is also a bag of sub RSpec dependencies.This helps with scenarios where one meta gem locks the update of another one, like in the following: