This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Update most remaining samples to the new APIs #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following samples crash because of an issue with the new Drawn handler: ColorSelection, DrawingArea and Pixbuf. The rest seem to work OK.
This allows the valtest sample to compile and work.
Accessing Dialog.ActionArea triggers a crash, so some samples fail because of that.
The action area is created as a GtkButtonBox, so casting it to a GtkHButtonBox doesn't work. And GtkHButtonBox is going to be deprecated in 3.2 anyway. This fixes a crash when accessing Dialog.ActionArea. With this, everything in sample/test seems to work OK.
mkestner
added a commit
that referenced
this pull request
Jun 30, 2011
Update most remaining samples to the new APIs
|
Thanks for the patches. Sorry for the delay getting them merged. |
|
No problem, thanks for getting them in ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most samples now build, but some of them trigger errors or crashes. See the various commit messages for more information.
I'll probably need some help to track down the underlying issues...