Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add US Virgin Islands zip codes #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpalacio-assurance
Copy link

@jpalacio-assurance jpalacio-assurance commented Dec 4, 2023

We are examining zip codes like 00803, 00850 as part of our application and noticed these were not included in the data. We did research and it seems including these ZIP codes (US Virgin Islands) would help to complete the dataset.

Resolves: #35

Copy link
Collaborator

@brodyhoskins brodyhoskins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data looks good, but I believe the correct :time_zone would be "America/Virgin" rather than "Canada/Halifax".

@elstgav
Copy link

elstgav commented Dec 13, 2023

Based off Wikipedia’s timezone article, it looks like the canonical zone would be "America/Puerto_Rico" instead?

@brodyhoskins
Copy link
Collaborator

The Wikipedia link shows that America/Virgin (and that it's linked to America/Puerto_Rico).

I'd argue we should use the more specific time zone for accuracy. It's not farfetched to think that one may change over time and introduce inaccuracies.

@NewAlexandria
Copy link

Feel free to also open a PR against https://github.com/suvie-eng/zip-codes/

I'm not wanting to create maintainer controversy - but until the maintainers here integrate all of these, I'd like to have a gem that is the most up to date. Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add US Virgin Islands zip codes
5 participants