Add session errors for control and data timeout #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengelbart
approved these changes
Nov 25, 2024
Co-authored-by: Mathis Engelbart <[email protected]>
ianswett
added
the
Design
ianswett
approved these changes
Dec 11, 2024
|
In general, a "data stream timeout" is going to result in a STOP_SENDING. I can squint and see a case for UNSUBSCRIBE. But killing the session is overkill, especially since a low priority stream or a lost RESET_STREAM frame can cause this timeout. So "data stream timeout" should not be a session-level error code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #459