Clarify End of track #635
Open
Clarify End of track #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afrind
reviewed
Dec 4, 2024
ianswett
approved these changes
Dec 10, 2024
ianswett
added
the
Object Model
ianswett
reviewed
Dec 11, 2024
afrind
reviewed
Dec 16, 2024
draft-ietf-moq-transport.md
Outdated
Comment on lines
2122
to
2126
| * 0x4 := Indicates end of Track. GroupID is one greater than the largest group | ||
| produced in this track and the ObjectId is zero. An object with this | ||
| status that has a Group ID less than or equal to any other Group ID, or | ||
| an Object ID other than zero, is a protocol error, and the receiver | ||
| MUST terminate the session. This SHOULD be cached. |
There was a problem hiding this comment.
Individual Comment:
The new formulation of END_OF_TRACK always has to be sent in it's own subgroup/stream, because it's in a new group. I think the intention behind END_OF_TRACK_AND_GROUP was to prevent this.
- Should we specify subgroup 0 for END_OF_TRACK or just let it be whatever?
- Can we add back END_OF_TRACK_AND_GROUP (0x4) with group ID=largest Group and objectID = largest Object +1, and move END_OF_TRACK to (0x5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #505.