Critical code review PR - Last sprint handover checklist of 0.10.0 release #147

vishwa-vyom · 2024-12-10T01:25:25Z

This PR is created just to add the review comments as part of the critical code review task of last sprint handover checklist for release of 0.10.0 version.

** THIS PR SHOULD NOT BE MERGED **

Earlier `/issuance/.well-known/openid-credential-issuer?version=v123` would return the latest versioned issuer metadata earlier if it was not valid, now returns an error. Signed-off-by: Harsh Vardhan <[email protected]>

Signed-off-by: Harsh Vardhan <[email protected]>

Signed-off-by: Challa Rao <[email protected]>

[DSD-5526] Update init_db.sh namespace and chart version

Signed-off-by: Harsh Vardhan <[email protected]>

[INJICERT-236] throw error when unsupported wellknown version requested

Signed-off-by: Challarao <[email protected]>

[INJICERT-37] rename certify database name

Signed-off-by: VSIVAKALYAN <[email protected]>

[DSD-5618] Update init_values.yaml

* [INJICERT-248] use well known config from spring from separate JSON file Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] fixup JSON formatting of well-known config Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] Fixup formatting & resource URL Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] add missing config for mock-identity Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] parse metadata when mediatype is text/plain Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] rename openid4vci well known file Signed-off-by: Harsh Vardhan <[email protected]> --------- Signed-off-by: Harsh Vardhan <[email protected]>

Signed-off-by: ckm007 <[email protected]>

[MOSIP-34749] removed platform related DB's reference

Signed-off-by: Praful Rakhade <[email protected]>

[DSD-5853] updated Dockerfile

Signed-off-by: Nandhukumar <[email protected]>

#49)" (#59) This reverts commit c1c4e43. Signed-off-by: Harsh Vardhan <[email protected]>

Signed-off-by: Rakshitha650 <[email protected]>

[MOSIP-34818]Updated values.yaml

Signed-off-by: Nandhukumar <[email protected]>

MOSIP-33742 | Created component based API test rig for Inji-certify

…ch (#148) * [INJICERT-499] added config docs for postgres dp plugin Signed-off-by: Piyush7034 <[email protected]> * Added upgrade sql scripts Signed-off-by: Piyush7034 <[email protected]> * Fixed template name Signed-off-by: Piyush7034 <[email protected]> * Fixed template name Signed-off-by: Piyush7034 <[email protected]> * Change in some configs w.r.t. data provider plugin Signed-off-by: Piyush7034 <[email protected]> --------- Signed-off-by: Piyush7034 <[email protected]> Signed-off-by: Vishwa <[email protected]>

vishwa-vyom

@vharsh @Piyush7034 Part 2 review done, reviewed till service layer of certify-service

certify-integration-api/src/main/java/io/mosip/certify/api/spi/DataProviderPlugin.java

certify-integration-api/src/main/java/io/mosip/certify/api/spi/VCFormatter.java

vishwa-vyom · 2024-12-12T13:02:04Z

certify-integration-api/src/main/java/io/mosip/certify/api/spi/VCSigner.java

+/**
+ * VCSigner can sign any VC provided a vcHash & Signer inputs
+ */
+public interface VCSigner {


Any special reason for this to be part of certify-integration-api and not certify-service ?

There is spi folder in both certify-core and certify-integration-api. All the interfaces are placed in these folders. So, it was placed in certify-integration-api. This can be moved to service folder of the certify-service

VCSigner and impl file to be moved to io.mosip.certify.vcsigners

certify-service/src/main/java/io/mosip/certify/CertifyServiceApplication.java

certify-service/src/main/java/io/mosip/certify/services/KeymanagerLibSigner.java

certify-service/src/main/java/io/mosip/certify/services/SVGRenderUtils.java

certify-service/src/main/java/io/mosip/certify/services/SvgTemplateServiceImpl.java

certify-service/src/main/java/io/mosip/certify/services/VCIssuanceServiceImpl.java

vishwa-vyom

@vharsh @Piyush7034 Last set review done,
api test, test file and deployment script are not reviewed.

certify-service/src/main/java/io/mosip/certify/services/ldsigner/Ed25519ProofSignature2018.java

certify-service/src/main/java/io/mosip/certify/services/SvgTemplateServiceImpl.java

...-service/src/main/java/io/mosip/certify/services/templating/VelocityTemplatingConstants.java

vishwa-vyom · 2024-12-13T07:03:39Z

...service/src/main/java/io/mosip/certify/services/templating/VelocityTemplatingEngineImpl.java

+    @Autowired
+    SvgTemplateService svgTemplateService;
+    @Value("${mosip.certify.vcformat.vc.expiry:true}")
+    boolean shouldHaveDates;


variable name and config name does not match

Would it be a good time to consider this feature enhancement here? It wasn't discussed but implemented directly.

ref: #132

Might need some changes in the config name, but largely ok.

Lets rename to mosip.certify.data-provider-plugin.vc-expiry-duration and use the java standard library for parsing.
Add the comments in the properties with the format and point to the ISO 8601

vishwa-vyom · 2024-12-13T08:24:37Z

docker-compose/docker-compose-injistack/docker-compose.yaml

+      - SPRING_CONFIG_NAME=certify
+      - SPRING_CONFIG_LOCATION=/home/mosip/config/
+      - enable_certify_artifactory=false
+      - download_hsm_client=false


We can add a small note to readme file to add the below environment variable to configure ngrok
mosipbox_public_url=https://nearly-notable-longhorn.ngrok-free.app

docs to be updated later

docker-compose/docker-compose-injistack/docker-compose.yaml

vishwa-vyom · 2024-12-13T08:30:21Z

docker-compose/docker-compose-injistack/nginx.conf

+        listen 80;
+
+        location / {
+            root /config/server;


why we have this config/server ?

@Piyush7034 to remove this and find out if that will work for him

@Piyush7034 Any update on this ?

There were issues while running docker on my machine. Thats why I couldn't remove

Signed-off-by: Nandhukumar <[email protected]>

MOSIP-38340 | Sync injicertify develop and release-0.10x branch

* [INJICERT-657] rename Svg -> SVG and other minor changes Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] make mass renames, update DB Changes: * svg_template DB becomes template_registry & it's ID column becomes a String from UUID type Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] move proofgenerator package Signed-off-by: Harsh Vardhan <[email protected]> * Docker and script code changes Signed-off-by: Piyush7034 <[email protected]> * [INJICERT-657] rename Certify keys in KeyManager Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] rename Certify keys in KeyManager Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] move VCFormatter & VCSigner to certify-service Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] make Velocity template cacheable Signed-off-by: Harsh Vardhan <[email protected]> --------- Signed-off-by: Harsh Vardhan <[email protected]> Signed-off-by: Piyush7034 <[email protected]> Co-authored-by: Piyush7034 <[email protected]> Signed-off-by: Vishwa <[email protected]>

Signed-off-by: Piyush7034 <[email protected]> Signed-off-by: Vishwa <[email protected]>

…es and docker Signed-off-by: Piyush7034 <[email protected]>

[INJICERT-657] Added review changed related to rendering template names and docker

* [INJICERT-657] pass keyID from CertifyIssuanceImpl Other changes: * more renames, changes to scripts & SQL files Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] use local CSV file for docker compose demo Signed-off-by: Harsh <[email protected]> * [INJICERT-657] remove & rename files Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] add optional expiry of VC in template Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] move packages around Signed-off-by: Harsh Vardhan <[email protected]> --------- Signed-off-by: Harsh Vardhan <[email protected]> Signed-off-by: Harsh <[email protected]> Signed-off-by: Vishwa <[email protected]>

Signed-off-by: Piyush7034 <[email protected]> Signed-off-by: Vishwa <[email protected]>

* [INJICERT-695] add mock mdoc VCI postman collection Signed-off-by: KiruthikaJeyashankar <[email protected]> * [INJICERT-695] modify property name of mdoc issuer key certificate mosip.certify.mock.vciplugin.issuer.key-cert changed to mosip.certify.mock.vciplugin.mdoc.issuer-key-cert Signed-off-by: KiruthikaJeyashankar <[email protected]> --------- Signed-off-by: KiruthikaJeyashankar <[email protected]> Signed-off-by: Vishwa <[email protected]>

* [INJICERT-657] Added some deployment changes Signed-off-by: Piyush7034 <[email protected]> * [INJICERT-657] Change in extraEnvVars yaml value Signed-off-by: Piyush7034 <[email protected]> --------- Signed-off-by: Piyush7034 <[email protected]> Signed-off-by: Vishwa <[email protected]>

Signed-off-by: Piyush7034 <[email protected]> Signed-off-by: Vishwa <[email protected]>

This reverts commit 443262e. Signed-off-by: Vishwa <[email protected]>

Signed-off-by: Harsh <[email protected]> Signed-off-by: Vishwa <[email protected]>

Signed-off-by: KiruthikaJeyashankar <[email protected]> Signed-off-by: Vishwa <[email protected]>

Signed-off-by: Harsh Vardhan <[email protected]> Signed-off-by: Vishwa <[email protected]>

…ified the docker compose file (#166) Signed-off-by: Vishwa <[email protected]>

Signed-off-by: Harsh <[email protected]>

…plate and docker compose pointed to collab (#168) Signed-off-by: Vishwa <[email protected]> Signed-off-by: Hitesh Jain <[email protected]> Co-authored-by: Hitesh Jain <[email protected]>

* [INJICERT-642] add dev & integrator docs Topics: * add plugin docs * add local development & setup guide * add docs for hosting a DID document Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-642] reorganize docs Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-642] update UINs to match collab setup data Signed-off-by: Harsh <[email protected]> * [INJICERT-642] update farmer logo and readme Signed-off-by: Harsh <[email protected]> * [INJICERT-642] remove redundant docs Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-642] update mDoc docs Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-642] remove mDoc secret generation script Signed-off-by: Harsh Vardhan <[email protected]> --------- Signed-off-by: Harsh Vardhan <[email protected]> Signed-off-by: Harsh <[email protected]> Signed-off-by: Vishwa <[email protected]>

Signed-off-by: Piyush7034 <[email protected]>

…ervice (#165) * [INJICERT-331] Added unit tests for validators and certify issuance service Signed-off-by: Piyush7034 <[email protected]> * Added proof generator and issuance services test cases Signed-off-by: Piyush7034 <[email protected]> * Added few more test for filter and services Signed-off-by: Piyush7034 <[email protected]> --------- Signed-off-by: Piyush7034 <[email protected]>

Signed-off-by: Harsh Vardhan <[email protected]>

* [INJICERT-657] update docs and issuer name Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] update mock mdl configurations Signed-off-by: Harsh Vardhan <[email protected]> --------- Signed-off-by: Harsh Vardhan <[email protected]>

Signed-off-by: Harsh <[email protected]>

vharsh and others added 30 commits June 17, 2024 10:22

[INJICERT-236] rename test funcs

f81a45e

Signed-off-by: Harsh Vardhan <[email protected]>

[DSD-5526] Update init_db.sh namespace and chart version

c90790b

Signed-off-by: Challa Rao <[email protected]>

Merge pull request #43 from challabeehyv/develop

8f13f8e

[DSD-5526] Update init_db.sh namespace and chart version

[INJICERT-236] remove redundant mock svc verify

8609818

Signed-off-by: Harsh Vardhan <[email protected]>

Merge pull request #35 from vharsh/injicert-236_randomVersion

3a80935

[INJICERT-236] throw error when unsupported wellknown version requested

[INJICERT-37] rename certify database name

0c30032

Signed-off-by: Challarao <[email protected]>

Merge pull request #46 from challabeehyv/database-rename

0e10a58

[INJICERT-37] rename certify database name

[DSD-5618] Update init_values.yaml

72b2bd5

Signed-off-by: VSIVAKALYAN <[email protected]>

Merge pull request #50 from VSIVAKALYAN/develop

61877b4

[DSD-5618] Update init_values.yaml

[MOSIP-34749] removed platform related DB's reference

b8eb49c

Signed-off-by: ckm007 <[email protected]>

Merge pull request #55 from ckm007/develop

ddc860b

[MOSIP-34749] removed platform related DB's reference

Updated Dockerfile

a227c5a

Signed-off-by: Praful Rakhade <[email protected]>

Merge pull request #57 from Prafulrakhade/develop

427d146

[DSD-5853] updated Dockerfile

MOSIP-33742

7993b24

Signed-off-by: Nandhukumar <[email protected]>

Merge remote-tracking branch 'upstream/develop' into develop

71d19db

Revert "[INJICERT-248] Simplify configuration of the well-known config (

3d03d13

#49)" (#59) This reverts commit c1c4e43. Signed-off-by: Harsh Vardhan <[email protected]>

[MOSIP-34818]Updated values.yaml

ad7d403

Signed-off-by: Rakshitha650 <[email protected]>

Update values.yaml

12f7412

Signed-off-by: Rakshitha650 <[email protected]>

Merge pull request #65 from Rakshitha650/patch-1

93d74fa

[MOSIP-34818]Updated values.yaml

MOSIP-33742

c25feee

Signed-off-by: Nandhukumar <[email protected]>

Merge remote-tracking branch 'upstream/develop' into develop

bcd3ba3

MOSIP-33742

286a70d

Signed-off-by: Nandhukumar <[email protected]>

MOSIP-33742

8b09bca

Signed-off-by: Nandhukumar <[email protected]>

MOSIP-33742

e157395

Signed-off-by: Nandhukumar <[email protected]>

MOSIP-33742

ed82986

Signed-off-by: Nandhukumar <[email protected]>

MOSIP-33742

dd42d41

Signed-off-by: Nandhukumar <[email protected]>

MOSIP-33742

5e87f7b

Signed-off-by: Nandhukumar <[email protected]>

Merge pull request #77 from nandhu-kumar/develop

55fea66

MOSIP-33742 | Created component based API test rig for Inji-certify

vishwa-vyom commented Dec 12, 2024

View reviewed changes

vishwa-vyom commented Dec 13, 2024

View reviewed changes

nandhu-kumar and others added 3 commits December 13, 2024 19:19

MOSIP-38340

c84ebe8

Signed-off-by: Nandhukumar <[email protected]>

MOSIP-38340

b1bda83

Signed-off-by: Nandhukumar <[email protected]>

Merge pull request #151 from nandhu-kumar/release-0.10.x

62de89c

MOSIP-38340 | Sync injicertify develop and release-0.10x branch

vishwa-vyom mentioned this pull request Dec 17, 2024

[INJICERT-657] rename Svg -> SVG and other minor changes #149

Merged

vharsh and others added 23 commits December 17, 2024 18:26

Added latest to vd11 and vd12 conversion methods (#152)

a2fa2f8

Signed-off-by: Piyush7034 <[email protected]> Signed-off-by: Vishwa <[email protected]>

[INJICERT-657] Added review changed related to rendering template nam…

821d46f

…es and docker Signed-off-by: Piyush7034 <[email protected]>

Merge pull request #154 from Infosys/review-changes

880c8b1

[INJICERT-657] Added review changed related to rendering template names and docker

[INJICERT-657] Added a fix to keep issuer metedata value fixed (#156)

0e1e9ac

Signed-off-by: Piyush7034 <[email protected]> Signed-off-by: Vishwa <[email protected]>

[INJICERT-657] add validFrom if missing from plugin (#157)

07b2c46

[INJICERT-657] Added condition for rsa and ed key generation (#159)

25a1685

Signed-off-by: Piyush7034 <[email protected]> Signed-off-by: Vishwa <[email protected]>

Revert "[INJICERT-657] Added some deployment changes (#158)" (#161)

abec8b2

This reverts commit 443262e. Signed-off-by: Vishwa <[email protected]>

[INJICERT-657] update SQL template scripts & fix VC key bug (#162)

87097b5

Signed-off-by: Harsh <[email protected]> Signed-off-by: Vishwa <[email protected]>

[INJICERT-695] add docker-compose setup for MDL (#163)

fe7ab48

Signed-off-by: KiruthikaJeyashankar <[email protected]> Signed-off-by: Vishwa <[email protected]>

[INJICERT-657] fixup duplicate hashing for RSA (#164)

0824983

Signed-off-by: Harsh Vardhan <[email protected]> Signed-off-by: Vishwa <[email protected]>

[INJICERT-789]: Added a new wellknown endpoint for did.json and simpl…

54dd04d

…ified the docker compose file (#166) Signed-off-by: Vishwa <[email protected]>

[INJICERT-657] change eSignet URLs to collab (#167)

4ca3de2

Signed-off-by: Harsh <[email protected]>

[INJICERT-789]: Changes done to pass on the holder id into the VC tem…

f40b385

…plate and docker compose pointed to collab (#168) Signed-off-by: Vishwa <[email protected]> Signed-off-by: Hitesh Jain <[email protected]> Co-authored-by: Hitesh Jain <[email protected]>

[INJICERT-657] Added reference link for postgres-plugin doc (#172)

f1e8903

Signed-off-by: Piyush7034 <[email protected]>

[INJICERT-657] add OpenAPI YAML & diagrams (#173)

97ffcd5

Signed-off-by: Harsh Vardhan <[email protected]>

[INJICERT-495] changes for svg template config (#180)

d320859

Signed-off-by: Harsh <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Critical code review PR - Last sprint handover checklist of 0.10.0 release #147

Critical code review PR - Last sprint handover checklist of 0.10.0 release #147

vishwa-vyom commented Dec 10, 2024

vishwa-vyom left a comment •

edited

Loading

vishwa-vyom Dec 12, 2024

Piyush7034 Dec 13, 2024

vishwa-vyom Dec 17, 2024

vishwa-vyom left a comment

vishwa-vyom Dec 13, 2024

vharsh Dec 16, 2024

vishwa-vyom Dec 16, 2024

vishwa-vyom Dec 17, 2024

vishwa-vyom Dec 13, 2024

vishwa-vyom Dec 17, 2024

vishwa-vyom Dec 13, 2024

vishwa-vyom Dec 17, 2024

vishwa-vyom Dec 17, 2024

Piyush7034 Dec 17, 2024

Critical code review PR - Last sprint handover checklist of 0.10.0 release #147

Are you sure you want to change the base?

Critical code review PR - Last sprint handover checklist of 0.10.0 release #147

Conversation

vishwa-vyom commented Dec 10, 2024

vishwa-vyom left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vishwa-vyom left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vishwa-vyom left a comment •

edited

Loading