Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INJICERT-331] Added unit tests for validators and certify issuance service #165

Merged
merged 3 commits into from
Jan 9, 2025
Merged

[INJICERT-331] Added unit tests for validators and certify issuance service #165

merged 3 commits into from
Jan 9, 2025

Conversation

Piyush7034
Copy link
Contributor

No description provided.

vharsh
vharsh approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@vharsh vharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo, we should exclude repositories package from the unit test coverage calculation and avoid writing either business logic inside there unless there's a good reason to do so

certify-service/src/test/java/io/mosip/certify/VCICacheServiceTest.java Outdated Show resolved Hide resolved
@Piyush7034 Piyush7034 force-pushed the test-coverage branch 3 times, most recently from 08707ea to 3e498c4 Compare January 3, 2025 13:34
vharsh
vharsh approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@vharsh vharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Piyush7034 Piyush7034 force-pushed the test-coverage branch 6 times, most recently from 785885b to 1209903 Compare January 7, 2025 12:05
jainhitesh9998
jainhitesh9998 requested changes Jan 8, 2025
View reviewed changes
certify-service/src/test/java/io/mosip/certify/filter/AccessTokenValidationFilterTest.java Outdated Show resolved Hide resolved
...e/src/test/java/io/mosip/certify/proofgenerators/Ed25519Signature2018ProofGeneratorTest.java Outdated Show resolved Hide resolved
...e/src/test/java/io/mosip/certify/proofgenerators/Ed25519Signature2020ProofGeneratorTest.java Outdated Show resolved Hide resolved
...e/src/test/java/io/mosip/certify/proofgenerators/Ed25519Signature2018ProofGeneratorTest.java Outdated Show resolved Hide resolved
...rvice/src/test/java/io/mosip/certify/proofgenerators/RSASignature2018ProofGeneratorTest.java Outdated Show resolved Hide resolved
certify-service/src/test/resources/application-test.properties Show resolved Hide resolved
@jainhitesh9998 jainhitesh9998 merged commit d2b4163 into mosip:release-0.10.x Jan 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainhitesh9998 jainhitesh9998 jainhitesh9998 approved these changes

@vharsh vharsh vharsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Piyush7034 @vharsh @jainhitesh9998