Create temporary files in a secure manner

Fixes ycm-core#2395.
motosir · Oct 24, 2016 · c991f04 · c991f04
1 parent f27787f
commit c991f04
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/python/ycm/youcompleteme.py b/python/ycm/youcompleteme.py
@@ -99,6 +99,7 @@ def PatchNoProxy():
   'script. See the documentation for more details.' )
 SERVER_IDLE_SUICIDE_SECONDS = 10800  # 3 hours
 DIAGNOSTIC_UI_FILETYPES = set( [ 'cpp', 'cs', 'c', 'objc', 'objcpp' ] )
+LOGFILE_FORMAT = 'ycmd_{port}_{std}_'
 
 
 class YouCompleteMe( object ):
@@ -143,13 +144,10 @@ def _SetupServer( self ):
                '--idle_suicide_seconds={0}'.format(
                   SERVER_IDLE_SUICIDE_SECONDS ) ]
 
-      filename_format = os.path.join( utils.PathToCreatedTempDir(),
-                                      'server_{port}_{std}.log' )
-
-      self._server_stdout = filename_format.format( port = server_port,
-                                                    std = 'stdout' )
-      self._server_stderr = filename_format.format( port = server_port,
-                                                    std = 'stderr' )
+      self._server_stdout = utils.CreateLogfile(
+          LOGFILE_FORMAT.format( port = server_port, std = 'stdout' ) )
+      self._server_stderr = utils.CreateLogfile(
+          LOGFILE_FORMAT.format( port = server_port, std = 'stderr' ) )
       args.append( '--stdout={0}'.format( self._server_stdout ) )
       args.append( '--stderr={0}'.format( self._server_stderr ) )
 

diff --git a/third_party/ycmd b/third_party/ycmd