-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Parsons Mailchimp connector #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial first pass. This is great. Only some minor changes needed, largely around comments for the documentation.
Also, please add:
mailchimp.rst
filemailchimp
to theindex.rst
file. See other classes for examples.mailchimp.py
import top level__init__.py
I added RST documentation in 4b1a3e0, and resolved other specific feedback in additional commits. Could you expand on what you mean by this, though, @jburchard?
|
Sure. Just import the class into this file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had the one comment. As per our conversation, it'd also be good to get some unit tests in before merging. This is great work! Thanks!
I added some testing with basic assertions, which we can expand upon down the road, and took care of the remaining feedback items. Ready for re-review. |
No description provided.