-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add script #845
add script #845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good - the only issue is the linting. Did you run Black?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like linting is still failing?
Hmm...interesting. I just ran black again and it said that the file was left unchanged. |
Can you share the full output of the Black command, as well as the location you're running the command from? |
(parsons) ➜ parsons git:(sample_ngpvan_printed_list) black useful_resources/sample_code/ngpvan_sample_printedlist.py |
So the instructions for how to use Black in the docs are wrong, whoops. Can you try |
…#1017) * black and flake8 linter fixes * Bump Multiple Docs Deps Around Sphinx (#975) * Bump multiple docs deps * Downgrade myst-parser --------- Co-authored-by: Soren Spicknall <[email protected]>
Thanks for the help @bmos but this PR is now including 3 extra files which it shouldn't need to touch. Any idea why/how to fix? |
Afaik that is because it was needed to get the linting check to pass. You can see the checks on the two commits in my PR. |
Now that you have updated the branch to main, it's using the new tooling which targets a longer line-length. |
It's probably easier for Sharine to just redo with a new PR off the most recent main branch. It's easy enough since it's a single file, and then she can run Black which will use whatever the current standards are. |
@shaunagm this is done! finally lol |
No description provided.