Fix issue with sdk doesnt send callback_url to web-service #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarrak
approved these changes
Dec 17, 2017
|
Thank you @MarkRady on the contribution. Extending the library with |
|
@MarkRady Please delete .DS_Store files to merge the PR. |
|
@ecleel You can check it now. |
|
@MarkRady Your PR is merged. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, You was get error message "callback_url":["can't be blank","is too short".. bla bla bla when create payment.
The Reason is web service need callback_url argument and php sdk wasn't send it.
Now you can pass callback_url as 5th argument
Payment::create($amount, $source, $description = "", $currency = "SAR", $callback_url)