Bug 1904329 - Fix Offer to Translate in Android r=android-reviewers,g…

…iorga, a=dmeehan

Changed from `SetGlobalOfferTranslateSettingAction` to `UpdateGlobalOfferTranslateSettingAction`.

`SetGlobalOfferTranslateSettingAction` - Used for setting the store.
`UpdateGlobalOfferTranslateSettingAction` - Used for setting the store and syncing with Gecko.

Differential Revision: https://phabricator.services.mozilla.com/D214869

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/translations/TranslationSettingsFragment.kt

@@ -108,7 +108,7 @@ class TranslationSettingsFragment : Fragment(), UserInteractionHandler {
                     isEnabled = true,
                     onStateChange = { _, checked ->
                         browserStore.dispatch(
-                            TranslationsAction.SetGlobalOfferTranslateSettingAction(
+                            TranslationsAction.UpdateGlobalOfferTranslateSettingAction(
                                 offerTranslation = checked,
                             ),
                         )

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/translations/TranslationsDialogMiddleware.kt

@@ -99,7 +99,7 @@ class TranslationsDialogMiddleware(
                     is TranslationPageSettingsOption.AlwaysOfferPopup -> {
                         // Ensures the translations engine has the correct value
                         browserStore.dispatch(
-                            TranslationsAction.SetGlobalOfferTranslateSettingAction(
+                            TranslationsAction.UpdateGlobalOfferTranslateSettingAction(
                                 offerTranslation = action.checkValue,
                             ),
                         )

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/translations/TranslationsDialogMiddlewareTest.kt

@@ -155,7 +155,7 @@ class TranslationsDialogMiddlewareTest {
         }
 
     @Test
-    fun `GIVEN translationState WHEN UpdatePageSettingsValue with action type AlwaysOfferPopup from TranslationDialogStore is called THEN call UpdatePageSettingAction from BrowserStore`() =
+    fun `GIVEN translationState WHEN UpdatePageSettingsValue with action type AlwaysOfferPopup from TranslationDialogStore is called THEN call UpdateGlobalOfferTranslateSettingAction from BrowserStore`() =
         runTest {
             assertTrue(settings.offerTranslation)
             val translationStore = TranslationsDialogStore(
@@ -173,7 +173,7 @@ class TranslationsDialogMiddlewareTest {
 
             verify {
                 browserStore.dispatch(
-                    TranslationsAction.SetGlobalOfferTranslateSettingAction(
+                    TranslationsAction.UpdateGlobalOfferTranslateSettingAction(
                         offerTranslation = false,
                     ),
                 )