Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use testling to run tests #158

Open
RickEyre opened this issue Nov 20, 2013 · 1 comment
Open

Use testling to run tests #158

RickEyre opened this issue Nov 20, 2013 · 1 comment

Comments

@RickEyre
Copy link
Contributor

If we want to make a real shim we need to be able to test on all browsers. We can do this a number of ways.

We can set up our own testling server and then have a git commit hook, or GitHub pull request hook, to run our tests. Or we can set up a local testling and Travis can run it for us hopefully.

If we get this set up we can separate the NodeVTT stuff out into a separate repo and pull it in for cue2json. Or even have NodeVTT do the stuff that cue2json does.

@RickEyre
Copy link
Contributor Author

RickEyre commented Dec 9, 2013

After #196 lands and it's landed in Gecko I think this should be the next priority as we're getting some issues on PhantomJS such as some CSS properties like unicode-bidirection and CSS units like 'vh' and 'vw' not being supported. document.createProcessingInstruction doesn't work as well. I'm in the middle of trying to figure out how to get PhantomJS to support these things (as they should since it's in there docs), but I think we might have to compile a version of PhantomJS ourselves to get that to work. Instead of going through all this we should just switch to Testling and switch node-vtt out into it's own repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant