Update processing model to most recent spec + add processing model tests #196
Conversation
|
It's failing because Travis is getting a different computed heights and width. Difference of like ~1px. I wonder if we could do something like have an acceptable range for computed styles or something... ? |
|
I'm going to disable tests that use computed styles in them for now because we need a more robust way of dealing with different computed styles on different systems. Later when we ass in the overlap avoidance there are going to be a lot of discrepancies like this. |
|
Switched to just doing parsing tests instead of disabling the tests completely... |
| @@ -11,7 +11,7 @@ module.exports = function( grunt ) { | |||
| curly: true, | |||
| eqeqeq: true, | |||
| newcap: true, | |||
| unused: true, | |||
| // Add this back once process algo is fixed // unused: true, | |||
There was a problem hiding this comment.
File a bug on this, link to it here.
|
A few comments and questions. I think this is generally fine. r=me when you've sorted this stuff out. |
|
Also, you should update the README to reflect the addition of |
|
Thanks for review Dave. So looking into the |
|
I'll open up a follow up bug for the |
These include changes for the new line alignment and position alignment settings.
|
Follow up issue filed as #204. |
Depends on #194 #187, #198.
Fixes #173, #148, #110.
This isn't ready to land yet as we need to land the others first and I still need to give it a once over to make sure that the tests are correct.
Some of the CSS settings we set don't currently work in PhantomJS for some reason, as well as
document.createProcessingInstruction. I'm currently trying to figure out how to get PhantomJS to support it as it's in the source and Chrome and Safari have it, so I would think PhantomJS would be able to have it as well. I've disabled processing model tests on time stamp tests for now for this reason.I don't think we should block on these things though and just fix them as we either get PhantomJS to support it or move to Testling. See #158 for more discussion.