Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix | Payload types #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phosph
Copy link

@phosph phosph commented Oct 10, 2024

This lib is very usefull. I made a small fix to updates the payload type

Refs:

Updates the payload type to use the spec's types not only string
Copy link
Owner

@mpetazzoni mpetazzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phosph, just one thing to address.

Comment on lines -2 to -3
/** Constructor. */
new (url: string, options?: SSEOptions): SSE;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe preserving this constructor definition is important, even though it is (somehow) not getting automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants