ytdl_hook: trigger hook only after profiles application #15674
Conversation
|
Download the artifacts for this pull request: |
|
Triggering auto-profiles before ytdl_hook sounds reasonable to me. However this would change the priority of the ytdl_hook from 10 (lower than the default) to 60. It's been 10 ever since the script was first added (0f7df89), and I'm inclined to think it's better to keep it that way as there might be several scripts out there that implicitly rely on the hook being executed early. Maybe instead just bump the priority of auto-profiles? |
|
auto-profiles priority is tricky, because depending on the use-case you may want it to be triggered before or after other hooks. I'm inclined to idea of making auto-profiles take priority over anything else on the off-chance that some user profiles will be affected by it, but fixing this fully, would require binding profiles to completely different hook or something... Also note that actions taken in profiles itself does not propagate immediately, most of the time it needs another tick to read new option. |
ytdl_hook and auto_profiles hook trigger in incorrect order leading to unexpected behavior like in #13515. This PR fixes the issue by ensuring that the ytdl_hook is always triggered after profiles have been applied.