Skip to content

Commit

Permalink
Refactor names in the codebase
Browse files Browse the repository at this point in the history
  • Loading branch information
jagodarybacka committed Feb 16, 2023
1 parent b1e6995 commit 9a4431f
Show file tree
Hide file tree
Showing 56 changed files with 196 additions and 193 deletions.
2 changes: 1 addition & 1 deletion .env.defaults
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ HIDE_IMPORT_DERIVATION_PATH=true
HIDE_SWAP_REWARDS=true
GAS_PRICE_POOLING_FREQUENCY=120
ETHEREUM_NETWORK=mainnet
WEBSITE_ORIGIN=https://tallyho.org
WEBSITE_ORIGIN=http://taho.xyz/
USE_MAINNET_FORK=false
MAINNET_FORK_URL="ws://mainnet-fork.tally.cash:2096/"
MAINNET_FORK_CHAIN_ID=1337
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/FEATURE.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ body:
label: What would you like to be able to do?
description: >-
Please describe what you would like to be able to achieve/what problem
you would like to be able to solve with Tally that you currently can't.
you would like to be able to solve with Taho that you currently can't.
validations:
required: true
12 changes: 6 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Tally Ho Contribution Guide
# Taho Contribution Guide

👍🎉 First off, thanks for taking the time to contribute! 🎉👍 Contributions
are welcome from anyone on the internet, and even the smallest of fixes are
appreciated!

The following is a set of guidelines for contributing to Tally Ho and its
The following is a set of guidelines for contributing to Taho and its
packages. These are mostly guidelines, not rules. Use your best judgment, and
feel free to propose changes to this document in a pull request. While the team
works towards a first release, bigger contributions will be slow-rolled or
Expand All @@ -13,8 +13,8 @@ to them very soon! More below.

## Deciding What to Work On

Tally Ho is currently being built by a core team in collaboration with a community
on the [Tally Ho Community Discord server](https://chat.tally.cash). **Discord is
Taho is currently being built by a core team in collaboration with a community
on the [Taho Community Discord server](https://chat.taho.xyz). **Discord is
the right place to start discussions on new features and bugs.** The community
on Discord, led by a few designated folks will help to funnel these into
well-organized GitHub issues for features and bugs, as well as organize folks
Expand Down Expand Up @@ -63,14 +63,14 @@ code base.

### Commit Signing

Commits on the Tally Ho repository are all required to be signed. No PR will be
Commits on the Taho repository are all required to be signed. No PR will be
merged if it has unsigned commits. See the [GitHub documentation on commit
signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
to get it set up.

### Continuous Integration

Tally Ho uses GitHub Actions for continuous integration. All Actions jobs
Taho uses GitHub Actions for continuous integration. All Actions jobs
(including tests, linting) must be green to merge a PR.

### Pre-commit
Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# tally-extension
# Taho Extension

<img alt="The community owned & operated wallet."
src="./github_[email protected]"
width="630" />

[Tally Ho](https://blog.tally.cash/a-community-owned-wallet-for-the-new-internet/)
[Taho](https://blog.taho.xyz/a-community-owned-wallet-for-the-new-internet/)
is a community owned and operated Web3 wallet, built as a
[browser extension](https://browserext.github.io/browserext/).

Expand All @@ -18,7 +18,7 @@ spirit of community ownership.

We can do better.

Tally Ho will be
Taho will be

- Fairly launched ⚖️
- Sustainably aligned with users 🤲
Expand Down Expand Up @@ -140,7 +140,7 @@ $ yarn start

### Commit signing

Commits on the Tally Ho repository are all required to be signed.
Commits on the Taho repository are all required to be signed.
No PR will be merged if it has unsigned commits. See the
[GitHub documentation on commit signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
to get it set up.
Expand Down Expand Up @@ -346,7 +346,7 @@ Firefox requires to upload source code if minifier is used and to be able to com

## Localization

Tally currently only supports English as the default language. We distill english strings to [\_locales](https://github.com/tallycash/extension/blob/main/ui/_locales/en/messages.json) to prepare for localization.
Taho currently only supports English as the default language. We distill english strings to [\_locales](https://github.com/tallycash/extension/blob/main/ui/_locales/en/messages.json) to prepare for localization.

For other languages, we will use language code defined in [Support locales](https://developer.chrome.com/docs/webstore/i18n/#choosing-locales-to-support). We will use [weblate](https://hosted.weblate.org/projects/tallycash/extension/) for crowd translation, and will commit back to the github periodically after these translations are QA'ed.

Expand Down
2 changes: 1 addition & 1 deletion babel.config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Global config for all babel-affected Tally Ho packages.
// Global config for all babel-affected Taho packages.
module.exports = {
plugins: ["styled-jsx/babel"],
presets: [
Expand Down
8 changes: 4 additions & 4 deletions background/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Tally Ho Background
# Taho Background

The Tally Ho Background package can effectively be considered the background script for the
Tally Ho extension. It is designed to connect to external data providers including
The Taho Background package can effectively be considered the background script for the
Taho extension. It is designed to connect to external data providers including
Ethereum nodes, as well as specific providers like Alchemy and Blocknative that
may enable specific functionality beyond the standard node functions. It constructs
a data model in the form of a [Redux](https://redux.js.org) store, which is
Expand Down Expand Up @@ -93,7 +93,7 @@ try to attribute networks (through variable and method naming) in the following

## Public API

The only public API of the Tally Ho Background package is what is exported directly on
The only public API of the Taho Background package is what is exported directly on
[`index.ts`](./index.ts). No submodule API is considered public, and all such
APIs are subject to arbitrary change without warning. Any API from a child
module that is meant for public consumption is re-exported in `index.ts`.
Expand Down
3 changes: 2 additions & 1 deletion background/constants/assets.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { SmartContractFungibleAsset } from "../assets"
import { ETHEREUM } from "./networks"
import { WEBSITE_ORIGIN } from "./website"

/**
* The primary token for the wallet's DAO.
Expand All @@ -14,6 +15,6 @@ export const DOGGO: SmartContractFungibleAsset = {
homeNetwork: ETHEREUM,
metadata: {
tokenLists: [],
websiteURL: "https://tallyho.cash",
websiteURL: WEBSITE_ORIGIN,
},
}
4 changes: 2 additions & 2 deletions background/constants/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ export const NETWORK_ERRORS = {
// 504:
// 504:
// internal:
UNSUPORTED_NETWORK: "Currently Tally does not support this network",
UNSUPORTED_TRANSPORT: "Currently Tally does not support this transport type",
UNSUPORTED_NETWORK: "Currently Taho does not support this network",
UNSUPORTED_TRANSPORT: "Currently Taho does not support this transport type",
CONNECT_NOT_SUPPORTED:
"The provided endpoint does not support socket connections",
SOCKET_CLOSED: "Connection with node is no longer open",
Expand Down
2 changes: 1 addition & 1 deletion background/constants/website.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
/* eslint-disable import/prefer-default-export */
export const WEBSITE_ORIGIN = process.env.WEBSITE_ORIGIN ?? null
export const WEBSITE_ORIGIN = process.env.WEBSITE_ORIGIN ?? ""
2 changes: 1 addition & 1 deletion background/lib/erc20.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export function parseERC20Tx(
}

/**
* Information bundle from an ostensible ERC20 transfer log using Tally types.
* Information bundle from an ostensible ERC20 transfer log using Taho types.
*/
export type ERC20TransferLog = {
contractAddress: string
Expand Down
4 changes: 2 additions & 2 deletions background/networks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export type LegacyEVMTransaction = EVMTransaction & {
* limit used to limit the gas expenditure on a transaction. This is used to
* request a signed transaction, and does not include signature fields.
*
* Nonce is permitted to be `undefined` as Tally internals can and often do
* Nonce is permitted to be `undefined` as Taho internals can and often do
* populate the nonce immediately before a request is signed.
*
* On networks that roll up to ethereum - the rollup fee is directly proportional
Expand Down Expand Up @@ -198,7 +198,7 @@ export type EIP1559Transaction = EVMTransaction & {
* limit the gas expenditure on a transaction. This is used to request a signed
* transaction, and does not include signature fields.
*
* Nonce is permitted to be `undefined` as Tally internals can and often do
* Nonce is permitted to be `undefined` as Taho internals can and often do
* populate the nonce immediately before a request is signed.
*/
export type EIP1559TransactionRequest = Pick<
Expand Down
2 changes: 1 addition & 1 deletion background/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@tallyho/tally-background",
"version": "0.0.1",
"description": "Tally Ho, the community owned and operated Web3 wallet: api implementation.",
"description": "Taho, the community owned and operated Web3 wallet: api implementation.",
"main": "index.ts",
"repository": "[email protected]:thesis/tally-extension.git",
"author": "Matt Luongo <[email protected]>",
Expand Down
2 changes: 1 addition & 1 deletion background/redux-slices/0x-swap.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ function build0xUrlFromSwapRequest(

// Depending on whether the set amount is buy or sell, request the trade.
// The /price endpoint is for RFQ-T indicative quotes, while /quote is for
// firm quotes, which the Tally UI calls "final" quotes that the user
// firm quotes, which the Taho UI calls "final" quotes that the user
// intends to fill.
const tradeField = "buyAmount" in amount ? "buyAmount" : "sellAmount"

Expand Down
4 changes: 2 additions & 2 deletions background/redux-slices/claim.ts
Original file line number Diff line number Diff line change
Expand Up @@ -325,12 +325,12 @@ export const signTokenDelegationData = createBackgroundAsyncThunk(
const delegatee = claim.selectedDelegate?.address

if (delegatee) {
const TallyTokenContract = await getContract(
const TahoTokenContract = await getContract(
DOGGO_TOKEN_ADDRESS,
ERC2612_INTERFACE
)

const nonce: BigNumber = await TallyTokenContract.nonces(address)
const nonce: BigNumber = await TahoTokenContract.nonces(address)
const nonceValue = Number(nonce)

const timestamp = await getCurrentTimestamp()
Expand Down
2 changes: 1 addition & 1 deletion background/services/keyring/encryption.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function requireCryptoGlobal(message?: string) {
if (global.crypto === undefined) {
throw new Error(
`${
message || "Tally"
message || "Taho"
} requires WebCrypto API support — is this being run in a modern browser?`
)
}
Expand Down
2 changes: 1 addition & 1 deletion background/services/preferences/defaults.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const defaultPreferences: Preferences = {
urls: [
storageGatewayURL(
"ipfs://bafybeigtlpxobme7utbketsaofgxqalgqzowhx24wlwwrtbzolgygmqorm"
).href, // the Tally community-curated list
).href, // the Taho community-curated list
"https://gateway.ipfs.io/ipns/tokens.uniswap.org", // the Uniswap default list
"https://meta.yearn.finance/api/tokens/list", // the Yearn list
"https://messari.io/tokenlist/messari-verified", // Messari-verified projects
Expand Down
2 changes: 1 addition & 1 deletion background/services/telemetry/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import logger from "../../lib/logger"
import { encodeJSON } from "../../lib/utils"

/**
* The TelemetryService is responsible for tracking usage statistics in Tally.
* The TelemetryService is responsible for tracking usage statistics in Taho.
*
* Currently we are only tracking extension storage information and logging
* it to the console.
Expand Down
4 changes: 2 additions & 2 deletions background/services/wallet-connect/sign-client-helper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ export default function createSignClient(): Promise<SignClient> {
relayUrl: "wss://relay.walletconnect.com",
metadata: {
// TODO: customize this metadata
name: "Tally Ho Wallet",
description: "WalletConnect for Tally Ho wallet",
name: "Taho Wallet",
description: "WalletConnect for Taho wallet",
url: "https://walletconnect.com/",
icons: ["https://avatars.githubusercontent.com/u/37784886"],
},
Expand Down
4 changes: 2 additions & 2 deletions background/third-party-data/blocknative/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ export const BlocknativeNetworkIds = {
// TODO Ethereum---either top-level or inside the instance.

/**
* The Blocknative class wraps access to the Blocknative API for the Tally
* extension backend. It exposes Tally-specific functionality, and manages
* The Blocknative class wraps access to the Blocknative API for the Taho
* extension backend. It exposes Taho-specific functionality, and manages
* connection and disconnection from Blocknative based on registered needs and
* feedback from the Blocknative system to minimize usage when possible.
*/
Expand Down
2 changes: 1 addition & 1 deletion dev-utils/local-chain/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "local-chain",
"description": "Local chain setup to support Tally Ho extension development.",
"description": "Local chain setup to support Taho extension development.",
"license": "GPL-3.0",
"private": true,
"repository": "https://github.com/tallycash/extension",
Expand Down
4 changes: 2 additions & 2 deletions manifest/manifest.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "Tally Ho",
"name": "Taho",
"version": "0.24.0",
"description": "The community owned and operated Web3 wallet.",
"homepage_url": "https://tally.cash",
Expand Down Expand Up @@ -29,7 +29,7 @@
"128": "icon-128.png"
},
"browser_action": {
"default_title": "Tally Ho",
"default_title": "Taho",
"default_popup": "popup.html"
},
"permissions": ["alarms", "storage", "unlimitedStorage", "activeTab"],
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@tallyho/tally-extension",
"private": true,
"version": "0.24.0",
"description": "Tally Ho, the community owned and operated Web3 wallet.",
"description": "Taho, the community owned and operated Web3 wallet.",
"main": "index.js",
"repository": "[email protected]:thesis/tally-extension.git",
"author": "Matt Luongo <[email protected]>",
Expand Down
2 changes: 1 addition & 1 deletion provider-bridge-shared/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@tallyho/provider-bridge-shared",
"version": "0.0.1",
"description": "Tally Ho, the community owned and operated Web3 wallet: provider bridge to connect the in-page provider with the background script.",
"description": "Taho, the community owned and operated Web3 wallet: provider bridge to connect the in-page provider with the background script.",
"main": "index.ts",
"repository": "[email protected]:thesis/tally-extension.git",
"author": "Greg Nagy <[email protected]>",
Expand Down
2 changes: 1 addition & 1 deletion provider-bridge/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export function injectTallyWindowProvider(): void {
container.insertBefore(scriptTag, container.children[0])
} catch (e) {
throw new Error(
`Tally: oh nos the content-script failed to initilaize the Tally window provider.
`Taho: oh nos the content-script failed to initilaize the Taho window provider.
${e}
It's time for a seppuku...🗡`
)
Expand Down
2 changes: 1 addition & 1 deletion provider-bridge/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@tallyho/provider-bridge",
"version": "0.0.1",
"description": "Tally Ho, the community owned and operated Web3 wallet: provider bridge to connect the in-page provider with the background script.",
"description": "Taho, the community owned and operated Web3 wallet: provider bridge to connect the in-page provider with the background script.",
"main": "index.ts",
"repository": "[email protected]:thesis/tally-extension.git",
"author": "Greg Nagy <[email protected]>",
Expand Down
12 changes: 6 additions & 6 deletions rfb/rfb-1-keyring-design.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

== Background

The Tally Ho wallet allows users to both view data associated with an account
The Taho wallet allows users to both view data associated with an account
of theirs, and sign transactions on behalf of that account using private key
material. Users can set up new accounts rooted in fresh private key material,
and accounts can derive many addresses via derivation paths as specified in
Expand All @@ -17,7 +17,7 @@ abstraction that is safe and functional.

=== Goal

The keyring is the core key management abstraction used by the Tally Ho wallet.
The keyring is the core key management abstraction used by the Taho wallet.
It is responsible for managing, securing access to, and protecting a user's
private key material, as well as exposing access to the public aspects of that
private key material.
Expand Down Expand Up @@ -53,7 +53,7 @@ derivation, signing, and related wallet work is done entirely by
http://ethers.io[Ethers].

Mnemonic management is done by the https://www.npmjs.com/package/bip39[bip39]
package. Tally Ho ``HDKeyring``s currently support any BIP39 mnemonics and
package. Taho ``HDKeyring``s currently support any BIP39 mnemonics and
mnemonic generation for any strength supported by the bip39 package.

Serialization of keyrings includes version information to allow for future
Expand All @@ -63,9 +63,9 @@ in order to protect the underlying mnemonic (and therefore private key).

==== Service

===== Tally Ho Services Abstraction
===== Taho Services Abstraction

Tally Ho services are runtime singletons that are charged with managing a
Taho services are runtime singletons that are charged with managing a
single slice of functionality for the extension. They manage data storage and
interactions with other services, as well as maintaining internal state.
Triggering a service’s functionality is currently done by invoking a method on
Expand All @@ -80,7 +80,7 @@ Once a service is created, it can be started and stopped. Currently services
can only walk through their lifecycle once, so once a service is stopped, it
can no longer be restarted.

Tally Ho services communicate data outwards in two ways:
Taho services communicate data outwards in two ways:

* All services have a set of events they may broadcast. These are expected to
be viewable by any external entity, and should only carry public (to the rest
Expand Down
4 changes: 2 additions & 2 deletions rfb/rfb-2-signers-ui.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Background

The Tally Ho wallet has always been meant to support a few things that haven't
The Taho wallet has always been meant to support a few things that haven't
yet been implemented. In particular, the wallet is expected to support
potentially many different types of out-of-memory signing---from connected
hardware wallets like Ledger and Trezor, to air-gapped hardware wallets like
Expand All @@ -27,7 +27,7 @@ the user is still reviewing the transaction.

### Current Functionality

The initial community edition release of Tally Ho featured a single way to add
The initial community edition release of Taho featured a single way to add
an account: via a mnemonic that created an underlying HDKeyring. A keyring is
an in-memory cryptographic base key that can derive multiple addresses and sign
for them with private key material. The community edition also supported a
Expand Down
4 changes: 2 additions & 2 deletions ui/README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Tally Ho Extension Frontend 🐕
# Taho Extension Frontend 🐕

![Screen + Browser Mock](https://user-images.githubusercontent.com/1918798/125732391-29da0e00-0796-49bb-895d-35de187b141d.png)

Welcome to the frontend portion of the Tally Ho browser extension. This is the
Welcome to the frontend portion of the Taho browser extension. This is the
React portion of the codebase which handles UI related states, and communicates
with the background script API `@tallyho/tally-background`. The intent is for
all communication with outside APIs to strictly happen within
Expand Down
Loading

0 comments on commit 9a4431f

Please sign in to comment.