-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a customization for saving a log file. #28
base: master
Are you sure you want to change the base?
Conversation
A great idea! Tell me when this is ready for review. Could you also fix the CI failure? |
Certainly, I'm embarrassed that I missed the CI tests. Any concerns with where I'm putting it? I am guessing things can get added/changed later with no real difficulty. |
I find I'm wanting to know how I've been doing over time, but don't have this recorded anywhere. So, quick stab to get that into this. I'm tempted to add a few extra outputs here. In particular, I suspect that I have a few keys I often miss, so would like to add any common letters that I'm missing to the output. If there is no objection, I think I can get that in here.
No reason to be embarrassed, I think I have to approve every run for "outside" contributors. |
I fixed the CI by adding a period. I can also reword the parameter, if we want to avoid the "if non-nil" opening of the sentence. |
Also, I'm going to work on adding the "missed characters" later. Trying to decide how I'd want that reported. Largely tempted to put it as a single "column" that is an alist of char to times missed. Could do json, though that would get odd for all of the commas that would make it need escaping for this to remain a CSV file? If you have thoughts on how that would be best done, I'm happy for directions. Similarly, if you want the log file done in a different way, happy to make any changes. |
Getting some time to polish this code up a bit. A couple of questions for you.
To the second question, I could introduce another parameter that lets us offer multiple format options. I'm hesitant to get too fancy there. My thinking is to record what is printed to the user, but in a flattened CSV style. So, each line would be:
I could add total-strokes and total words? For the code organization, I'm not looking to refactor too much here. I can move out the writing of the file, otherwise, I'm planning on making it so that it saves the file, but don't have any other plans here. If there is another set of methods I should use instead of Thanks! |
The name sounds good to me!
I think since this is Emacs, the most natural solution would be to write an s-expression like in e.g. |
I find I'm wanting to know how I've been doing over time, but don't have this recorded anywhere. So, quick stab to get that into this.
I'm tempted to add a few extra outputs here. In particular, I suspect that I have a few keys I often miss, so would like to add any common letters that I'm missing to the output. If there is no objection, I think I can get that in here.