Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase nginx file upload size limit to 100 MB #655

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

geordi
Copy link
Member

@geordi geordi commented Mar 24, 2025

No description provided.

@geordi geordi requested a review from Kobzol March 24, 2025 15:00
Copy link
Collaborator

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That was not that hard, after all =D

@@ -28,6 +28,8 @@ http {
include /etc/nginx/mime.types;
}

client_max_body_size 100M;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment to keep this in sync with settings.py?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment added.

Copy link
Collaborator

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on production, seems to work 👍 I would suggest to lower the size both in nginx and settings.py to 25 MiB though. Going from 1 MiB to 100 MiB is quite the jump :)

@Kobzol
Copy link
Collaborator

Kobzol commented Mar 24, 2025

Btw we will need to manually modify kelvin_deploy/nginx.conf, the configuration file in the repository is just an example.

@geordi
Copy link
Member Author

geordi commented Mar 24, 2025

I had a few projects in UPR course that were ~75 MB. So I'd like to keep it like this at the moment, if you don't mind. We can run some stats after the semster regarding the submit sizes.

Tested on production, seems to work 👍 I would suggest to lower the size both in nginx and settings.py to 25 MiB though. Going from 1 MiB to 100 MiB is quite the jump :)

@geordi geordi force-pushed the nginx-file-size-limit branch from e258b05 to 52fe1d5 Compare March 24, 2025 18:46
@Kobzol
Copy link
Collaborator

Kobzol commented Mar 24, 2025

Ok :)

@geordi geordi added this pull request to the merge queue Mar 24, 2025
Merged via the queue into master with commit c75b1ee Mar 24, 2025
5 checks passed
@geordi geordi deleted the nginx-file-size-limit branch March 24, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants