Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to fix image build instructions. #56

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Update README.md to fix image build instructions. #56

merged 1 commit into from
Feb 18, 2022

Conversation

jimmywan
Copy link
Contributor

@jimmywan jimmywan commented Oct 8, 2021 •
edited
Loading

Fix docker build to use --build-arg.

Checklist

Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.

  • CI passes
  • Description of proposed change
  • Documentation (README, docs/, man pages) is updated
  • Existing issue is referenced if there is one
  • Unit tests for the proposed change

Fixes #58

@jimmywan
Update README.md
bb1420c 
Fix docker build to use --build-arg.
@jimmywan jimmywan changed the title Update README.md Update README.md to fix image build instructions. Oct 13, 2021
@jimmywan jimmywan mentioned this pull request Oct 21, 2021
Closed
5 tasks
@mrtazz
Copy link
Owner

mrtazz commented Feb 18, 2022

thanks for the contribution!

@mrtazz mrtazz merged commit c4c569e into mrtazz:main Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker image build instructions are incorrect
2 participants
@jimmywan @mrtazz