Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example Typescript project #12

Open
wants to merge 1 commit into
base: monodevelop
Choose a base branch
from

Conversation

chrisber
Copy link
Contributor

This pull request adds the example project provided from VS.
It also adds the resources folder to show file icons.

@mrward
Copy link
Owner

mrward commented Apr 19, 2015

I think we need to be careful just copying Visual Studio's project template. I tend to avoid copying and pasting templates from Visual Studio. I think we should create our own templates which are not are not exact copies.

How do you run the project so you can see the HTML page? I would be tempted to create an empty ASP.NET project with a single HTML page. That way you could run the project and see the html page and test the JavaScript.

Other problems with the pull request I can see:

You have added a custom startup command which will only work on Linux.

You have added another syntax highlighting and mime type which is different to the existing mimetype and syntax highlighting which is built in to MonoDevelop. Why do we need a separate one?

The project type is a resource but the file template is a just a file. Can we make these consistent? I would just copy the template to the output directory next to the file template.

For the icon resources I would give them a logical resource name in the property window so you do not have put the full resource name in the addin.xml file:

resource="ICSharpCode.TypeScriptBinding.Resources.TypeScript.Template.EmptyFile.png"

So you could use something like the following instead:

 resource="TypeScript.Template.EmptyFile.png"

@mrward
Copy link
Owner

mrward commented Apr 19, 2015

Looking at the project template that Visual Studio creates they are creating a web application with the project type guids of:

   <ProjectTypeGuids>{349c5851-65df-11da-9384-00065b846f21};{fae04ec0-301f-11d3-bf4b-00c04f79efbc}</ProjectTypeGuids>

This is the same project type guids that MonoDevelop creates for an empty ASP.NET project. Visual Studio also has extra MSBuild targets which build the TypeScript files which we do not support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants