Avoid unnecessary allocation from realloc

msabwat · Feb 2, 2019 · 85cf5dd · 85cf5dd
1 parent c0ceb6e
commit 85cf5dd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/mem/slab.h b/src/mem/slab.h
@@ -71,7 +71,7 @@ namespace snmalloc
 
       meta.debug_slab_invariant(is_short(), this);
 
-      if (zero_mem == YesZero)
+      if constexpr (zero_mem == YesZero)
       {
         if (rsize < PAGE_ALIGNED_SIZE)
           memory_provider.zero(p, rsize);

diff --git a/src/override/malloc.cc b/src/override/malloc.cc
@@ -80,13 +80,14 @@ extern "C"
         "Calling realloc on pointer that is not to the start of an allocation");
     }
 #endif
+    if (size <= SNMALLOC_NAME_MANGLE(malloc_usable_size)(ptr))
+      return ptr;
+
     void* p = SNMALLOC_NAME_MANGLE(malloc)(size);
-    if (p)
+    if (p != nullptr)
     {
       assert(p == Alloc::external_pointer<Start>(p));
-      size_t sz =
-        (std::min)(size, SNMALLOC_NAME_MANGLE(malloc_usable_size)(ptr));
-      memcpy(p, ptr, sz);
+      memcpy(p, ptr, size);
       SNMALLOC_NAME_MANGLE(free)(ptr);
     }
     return p;