Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #212; Let Encoder#encode() return a copy of the internal buffer #213

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

gfx
Copy link
Member

@gfx gfx commented Sep 2, 2022

This is an intentional behavior but I'll change it because it's confusing.

See #212 and the added tests for details.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #213 (f1b3f84) into main (9b4123a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files          16       16           
  Lines         964      966    +2     
  Branches      206      206           
=======================================
+ Hits          946      948    +2     
  Misses         18       18           
Impacted Files Coverage Δ
src/Encoder.ts 98.00% <100.00%> (+0.01%) ⬆️
src/encode.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gfx gfx merged commit da998c6 into main Sep 2, 2022
@gfx gfx deleted the gfx/fix-212 branch September 2, 2022 02:37
@gfx gfx mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants