p2p/discv5: make idx bounds checking more sound (ethereum#17571)

mslipper · Sep 3, 2018 · 5c0954a · 5c0954a
1 parent 62e9489
commit 5c0954a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/p2p/discv5/net.go b/p2p/discv5/net.go
@@ -1228,7 +1228,7 @@ func (net *Network) checkTopicRegister(data *topicRegister) (*pong, error) {
 	if rlpHash(data.Topics) != pongpkt.data.(*pong).TopicHash {
 		return nil, errors.New("topic hash mismatch")
 	}
-	if int(data.Idx) < 0 || int(data.Idx) >= len(data.Topics) {
+	if data.Idx >= uint(len(data.Topics)) {
 		return nil, errors.New("topic index out of range")
 	}
 	return pongpkt.data.(*pong), nil