refactor(pullRequest): use context to read PR labels

mtxr · Feb 4, 2020 · e603501 · e603501
1 parent fd9f10d
commit e603501
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 19 deletions.
diff --git a/__tests__/handler.test.ts b/__tests__/handler.test.ts
@@ -20,6 +20,7 @@ describe('handlePullRequest', () => {
         number: '1',
         pull_request: {
           number: 1,
+          labels: [],
           title: 'test',
           user: {
             login: 'pr-creator',
@@ -831,11 +832,7 @@ describe('handlePullRequest', () => {
       labels: ['test_label'],
     } as any
 
-    client.issues = {
-      listLabelsOnIssue: jest
-        .fn()
-        .mockResolvedValue({ data: [{ name: 'some_label' }] }),
-    } as any
+    context.payload.pull_request.labels = [{ name: 'some_label' }]
 
     await handler.handlePullRequest(client, context, config)
 
@@ -855,12 +852,7 @@ describe('handlePullRequest', () => {
 
     const client = new github.GitHub('token')
 
-    client.issues = {
-      addAssignees: jest.fn().mockImplementation(async () => {}),
-      listLabelsOnIssue: jest
-        .fn()
-        .mockResolvedValue({ data: [{ name: 'some_label' }] }),
-    } as any
+    context.payload.pull_request.labels = [{ name: 'some_label' }]
 
     client.pulls = {
       createReviewRequest: jest.fn().mockImplementation(async () => {}),

diff --git a/src/handler.ts b/src/handler.ts
@@ -69,7 +69,7 @@ export async function handlePullRequest(
   const pr = new PullRequest(client, context)
 
   if (labels !== undefined && labels.length > 0) {
-    const hasLabels = await pr.hasAnyLabel(labels)
+    const hasLabels = pr.hasAnyLabel(labels)
     if (!hasLabels) {
       core.info(
         'Skips the process to add reviewers/assignees since PR is not tagged with any of the labels'

diff --git a/src/pull_request.ts b/src/pull_request.ts
@@ -33,13 +33,11 @@ export class PullRequest {
     core.debug(JSON.stringify(result))
   }
 
-  async hasAnyLabel(labels: string[]): Promise<boolean> {
-    const { owner, repo, number: pull_number } = this.context.issue
-    const pullRequestLabels = (await this.client.issues.listLabelsOnIssue({
-      issue_number: pull_number,
-      owner,
-      repo,
-    })).data
+  hasAnyLabel(labels: string[]): boolean {
+    if (!this.context.payload.pull_request) {
+      return false
+    }
+    const { labels: pullRequestLabels = [] } = this.context.payload.pull_request
     return pullRequestLabels.some(label => labels.includes(label.name))
   }
 }