Allow custom secrets path and multiple passwords for the same website #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerard-CK
force-pushed
the
custom_secrets_path
branch
from
ebbbc08 to
f062a5e
Compare
|
Just a nudge on this. Are these new features of any interest? |
|
very much of interest, I was sick for a few days and got swamped with work. I do have some time now and will try to finish the review for both PRs today |
added 4 commits
January 26, 2023 16:09
Read any other username/password pairs from any given secret on top of the default "username"/"password" pair
For example, if a secret has the following keys:
{
"username": "myusername",
"password": "mypassword",
"username.2": "other username",
"password.2": "other password",
"username for test": "test username",
"password for test": "test password"
}
then 3 sets of credentials will be loaded for that one secret:
myusername/mypassword
other username/other password
and
test username/test password
mulbc
force-pushed
the
custom_secrets_path
branch
from
f062a5e to
5507d5c
Compare
To avoid to many false positive, only widen the search for a potential username field to generic text fields when a password field is in a form or the user manually requested credentials to be filled on the current web page
mulbc
force-pushed
the
custom_secrets_path
branch
from
5507d5c to
2b854b1
Compare
|
@Gerard-CK - I rebased your code on the other PR that I merged before. It all looks fine to me and I'm ready to merge, just wanted to give you a chance to have a quick look over it yourself if you have the time |
|
Hi, sorry to hear that you were sick but good to hear you're back and in good shape. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively big PR with major enhancements.
I suggest reviewing one commit at a time starting from the oldest one first.
Enhancement 1:
Allow more than one password per website. VaultPass can now extract multiple username/password pairs from any given secret [possibly address issue #33]
Enhancement 2:
User can specify which KV store they wish to use (the default still being /secret/vaultPass) [possibly address issue #20]
Bug fixes:
No matching key found for this pageonly once instead of once per selected directory