Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint errors #6

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Fix eslint errors #6

merged 1 commit into from
Feb 6, 2019

Conversation

mulbc
Copy link
Owner

@mulbc mulbc commented Feb 4, 2019

Fixes two eslint issues in file.

Fixed two eslint issues:
* Use single quotes for strings
* Set semicolons after commands

Signed-off-by: Chris Blum <[email protected]>
Copy link
Collaborator

@ThibaultJanBeyer ThibaultJanBeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

Did you take a look on airbnbs eslint recommendations? That has become the standart in frontend somehow… We can also use it

@mulbc
Copy link
Owner Author

mulbc commented Feb 5, 2019

Can you please add a link? As far as I could see... AirBnB has three eslint config files they offer:
https://www.npmjs.com/package/eslint-config-airbnb

@ThibaultJanBeyer
Copy link
Collaborator

For non-react projects, that should be this one: https://www.npmjs.com/package/eslint-config-airbnb-base

@mulbc mulbc merged commit ef6e2b5 into master Feb 6, 2019
@mulbc mulbc deleted the Fix-eslint branch February 6, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants