Merge pull request hashicorp#64 from hashicorp/variables-create-allow…

…-empty-string

Allow creation of variables with no value

variable.go

@@ -129,9 +129,6 @@ func (o VariableCreateOptions) valid() error {
 	if !validString(o.Key) {
 		return errors.New("key is required")
 	}
-	if !validString(o.Value) {
-		return errors.New("value is required")
-	}
 	if o.Category == nil {
 		return errors.New("category is required")
 	}

variable_test.go

@@ -107,15 +107,41 @@ func TestVariablesCreate(t *testing.T) {
 		assert.EqualError(t, err, "key is required")
 	})
 
+	t.Run("when options has an empty key", func(t *testing.T) {
+		options := VariableCreateOptions{
+			Key:       String(""),
+			Value:     String(randomString(t)),
+			Category:  Category(CategoryTerraform),
+			Workspace: wTest,
+		}
+
+		_, err := client.Variables.Create(ctx, options)
+		assert.EqualError(t, err, "key is required")
+	})
+
 	t.Run("when options is missing value", func(t *testing.T) {
 		options := VariableCreateOptions{
 			Key:       String(randomString(t)),
 			Category:  Category(CategoryTerraform),
 			Workspace: wTest,
 		}
 
-		_, err := client.Variables.Create(ctx, options)
-		assert.EqualError(t, err, "value is required")
+		v, err := client.Variables.Create(ctx, options)
+		require.NoError(t, err)
+		assert.Equal(t, "", v.Value)
+	})
+
+	t.Run("when options has an empty string value", func(t *testing.T) {
+		options := VariableCreateOptions{
+			Key:       String(randomString(t)),
+			Value:     String(""),
+			Category:  Category(CategoryTerraform),
+			Workspace: wTest,
+		}
+
+		v, err := client.Variables.Create(ctx, options)
+		require.NoError(t, err)
+		assert.Equal(t, *options.Value, v.Value)
 	})
 
 	t.Run("when options is missing category", func(t *testing.T) {