This repository has been archived by the owner on Jun 9, 2021. It is now read-only.
update usage information #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings README.md and the usage printed by the command into sync, and also adds information about available attributes. I've reverse-engineered the descriptions from my idea of what the code might be doing, so they're quite likely wrong :)
mvdan
approved these changes
Mar 10, 2021
| The node is an identifier that matches the regular expression. | ||
| type(type) | ||
| The node has the given Go type. | ||
| TODO how are packages referred to? |
There was a problem hiding this comment.
packages are referred to as per the scope where the node is located, if I recall correctly.
I also seem to recall this is an area that I wasn't too happy with. The ideal solution might be local scope plus some sort of fallback, like goimports-like resolution. Or perhaps something more explicit, like what rsc/rf does.
| @@ -17,6 +17,7 @@ A command is of the form "-A pattern", where -A is one of: | |||
| -v discard nodes matching a pattern | |||
| -a filter nodes by certain attributes | |||
| -s substitute with a given syntax tree | |||
| -p number navigate up a number of node parents | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings README.md and the usage printed by the command
into sync, and also adds information about available attributes.
I've reverse-engineered the descriptions from my idea of what the
code might be doing, so they're quite likely wrong :)