expression: implement vectorized evaluation for `builtinLastInsertIDW…

…ithIDSig` (pingcap#12839)
mygh2012 · Nov 5, 2019 · 622e8aa · 622e8aa
1 parent 9ada79a
commit 622e8aa
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/expression/builtin_info_vec.go b/expression/builtin_info_vec.go
@@ -129,11 +129,21 @@ func (b *builtinLastInsertIDSig) vecEvalInt(input *chunk.Chunk, result *chunk.Co
 }
 
 func (b *builtinLastInsertIDWithIDSig) vectorized() bool {
-	return false
+	return true
 }
 
 func (b *builtinLastInsertIDWithIDSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
+	if err := b.args[0].VecEvalInt(b.ctx, input, result); err != nil {
+		return err
+	}
+	i64s := result.Int64s()
+	for i := len(i64s) - 1; i >= 0; i-- {
+		if !result.IsNull(i) {
+			b.ctx.GetSessionVars().SetLastInsertID(uint64(i64s[i]))
+			break
+		}
+	}
+	return nil
 }
 
 func (b *builtinVersionSig) vectorized() bool {

diff --git a/expression/builtin_info_vec_test.go b/expression/builtin_info_vec_test.go
@@ -36,6 +36,7 @@ var vecBuiltinInfoCases = map[string][]vecExprBenchCase{
 	ast.ConnectionID:   {},
 	ast.LastInsertId: {
 		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{}},
+		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETInt}},
 	},
 }