expression: implement vectorized evaluation for builtinPI and make …

…testing framework support functions without input arguments (pingcap#12620)
mygh2012 · Oct 11, 2019 · cf06460 · cf06460
1 parent 5e85812
commit cf06460
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/expression/bench_test.go b/expression/bench_test.go
@@ -657,6 +657,9 @@ func genVecBuiltinFuncBenchCase(ctx sessionctx.Context, funcName string, testCas
 		fillColumn(eType, input, i, testCase)
 		cols[i] = &Column{Index: i, RetType: fts[i]}
 	}
+	if len(cols) == 0 {
+		input.SetNumVirtualRows(1024)
+	}
 
 	var err error
 	if funcName == ast.Cast {

diff --git a/expression/builtin_math_vec.go b/expression/builtin_math_vec.go
@@ -665,11 +665,17 @@ func (b *builtinCRC32Sig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) e
 }
 
 func (b *builtinPISig) vectorized() bool {
-	return false
+	return true
 }
 
 func (b *builtinPISig) vecEvalReal(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
+	n := input.NumRows()
+	result.ResizeFloat64(n, false)
+	f64s := result.Float64s()
+	for i := range f64s {
+		f64s[i] = math.Pi
+	}
+	return nil
 }
 
 func (b *builtinRandSig) vectorized() bool {

diff --git a/expression/builtin_math_vec_test.go b/expression/builtin_math_vec_test.go
@@ -99,6 +99,9 @@ var vecBuiltinMathCases = map[string][]vecExprBenchCase{
 		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETInt}, childrenFieldTypes: []*types.FieldType{{Tp: mysql.TypeInt24}}, geners: nil},
 		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETDecimal}, geners: nil},
 	},
+	ast.PI: {
+		{retEvalType: types.ETReal},
+	},
 	ast.Truncate: {
 		{retEvalType: types.ETReal, childrenTypes: []types.EvalType{types.ETReal, types.ETInt}, geners: []dataGenerator{nil, &rangeInt64Gener{-10, 10}}},
 		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETInt, types.ETInt}, geners: []dataGenerator{nil, &rangeInt64Gener{-10, 10}}},