Skip to content

Commit

Permalink
Only increment download counter on files that have a download limit
Browse files Browse the repository at this point in the history
For files that have no limit, there is no reason to track the download counter as its value will never be used anyway. This reduces costs on storage backends that have an operation fee (e.g. AWS S3) or a minimum retention (e.g. Wasabi S3).
  • Loading branch information
JustAnotherArchivist committed Apr 25, 2021
1 parent 31ef712 commit 6bd3e97
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion server/handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ func (s *Server) CheckMetadata(token, filename string, increaseDownload bool) (M
return metadata, errors.New("MaxDownloads expired.")
} else if !metadata.MaxDate.IsZero() && time.Now().After(metadata.MaxDate) {
return metadata, errors.New("MaxDate expired.")
} else if increaseDownload {
} else if metadata.MaxDownloads != -1 && increaseDownload {
// todo(nl5887): mutex?

// update number of downloads
Expand Down

0 comments on commit 6bd3e97

Please sign in to comment.