Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FixaMinGata] Hide app badges when using PWABuilder #5311

Conversation

jonkri
Copy link
Contributor

@jonkri jonkri commented Dec 30, 2024

Please check the following:

  • Has the code POD documentation been added or updated?
  • Whether this PR should include changes to any public documentation, or the FAQ;
  • All cobrand-specific commits start their commit message with the cobrand in square brackets;
  • Is new functionality tested? CodeCov will warn you about the diff coverage, but won’t complain about e.g. new files;
  • Will cobrand-specific changes require additional work to ensure consistent behaviour on www.fixmystreet.com?
  • Are the changes tested for accessibility?
  • Have you updated the changelog? If this is not necessary, put square brackets around this: skip changelog

The app-platform cookie comes from the PWABuilder code:

$ grep -Inr app-platform
./src/FixaMinGata/Settings.swift:22:let platformCookie = Cookie(name: "app-platform", value: "iOS App Store")

It has worked okay for us. The app icons are visible outside of the iOS app but hidden inside the iOS app.

Apple rejected the app until we made that change.

Related to #4153.

@dracos dracos force-pushed the fixamingata-hide-app-badges-when-using-pwabuilder branch from 2b76f29 to 3ed1e1e Compare January 22, 2025 18:56
@dracos dracos merged commit 3ed1e1e into mysociety:master Jan 22, 2025
9 checks passed
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.44%. Comparing base (13d30dc) to head (3ed1e1e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5311      +/-   ##
==========================================
+ Coverage   82.43%   82.44%   +0.01%     
==========================================
  Files         416      416              
  Lines       32894    32890       -4     
  Branches     5281     5281              
==========================================
+ Hits        27116    27117       +1     
+ Misses       4220     4215       -5     
  Partials     1558     1558              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants