[Brent] [Waste] General waste bin signposting text changes. #5327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5327 +/- ##
==========================================
+ Coverage 82.42% 82.44% +0.01%
==========================================
Files 416 416
Lines 32896 32892 -4
Branches 5281 5281
==========================================
+ Hits 27115 27118 +3
+ Misses 4221 4215 -6
+ Partials 1560 1559 -1 ☔ View full report in Codecov by Sentry. |
dracos
requested changes
Jan 16, 2025
There was a problem hiding this comment.
For accessibility reasons, could we change the last paragraph they asked us to change - "form" is not good link text (it may be read out independently). I would suggest that the whole paragraph should be a link to the form and the text should be the call to action, eg "Request a new or replacement rubbish bin".
Looks like a corresponding test needs updating as well.
neprune
force-pushed
the
brent-update-general-waste-bin-signposting
branch
from
b2ea426 to
0411343
Compare
dracos
approved these changes
Jan 16, 2025
neprune
force-pushed
the
brent-update-general-waste-bin-signposting
branch
from
0411343 to
ec7b603
Compare
|
Changes made so new text goes live from the 27th. |
dracos
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip changelog]
https://mysocietysupport.freshdesk.com/a/tickets/5028