fix bug in cran_summary() (r-hub#261)

fix r-hub#259
mzkaramat · May 2, 2019 · d6b10b7 · d6b10b7
1 parent 5180a33
commit d6b10b7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,10 @@
 
 # dev
 
+## Bug fixes
+
+* `cran_summary()` now works even if there is a NOTE/WARNING/ERROR in one platform and nothing on other platforms (@fabian-s, #259).
+
 # rhub 1.1.1
 
 ## Enhancements

diff --git a/R/check-class.R b/R/check-class.R
@@ -248,14 +248,18 @@ check_cran_summary <- function(self, private) {
 
   result <- do.call("rbind",
                     lapply(x, rectangle_status))
+
   systems <- paste0("- R-hub ",
                     vapply(x, function(xx) xx$platform$name, ""),
                     " (",
                     vapply(x, function(xx) xx$platform$rversion, ""),
                     ")")
   lines <- paste0(systems, "\n")
 
-  if ("hash" %in% names(result)){
+
+  result <- result[!is.na(result$type),]
+
+  if (nrow(result) > 0){
     message("For a CRAN submission we recommend that you fix all NOTEs, WARNINGs and ERRORs.")
     unique_results <- unique(result[, c("type", "hash")])
 
@@ -326,7 +330,10 @@ rectangle_status <- function(x){
   df <- df[df$message != "",]
 
   if(nrow(df) == 0){
-    df <- data.frame(package = x$package)
+    df <- data.frame(package = x$package,
+                     type = NA,
+                     message = NA, 
+                     hash = NA)
   } else{
     df$hash <- hash_check(df$message)
   }