Skip to content

Commit

Permalink
fix: docs Cloudflare build (QwikDev#5329)
Browse files Browse the repository at this point in the history
* chore: fix failing cloudflare build
* fix: change @supabase/supabase-js version

---------

Co-authored-by: Miško Hevery <[email protected]>
  • Loading branch information
gioboa and mhevery authored Oct 18, 2023
1 parent e61c17b commit 115cc7d
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@modular-forms/qwik": "^0.21.0",
"@mui/material": "^5.14.13",
"@mui/x-data-grid": "^6.16.1",
"@supabase/supabase-js": "^2.38.0",
"@supabase/supabase-js": "2.33.1",
"@types/prismjs": "^1.26.1",
"@types/react": "^18.2.28",
"@types/react-dom": "^18.2.13",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Thanks to [Resumability](/docs/(qwik)/concepts/resumable/index.mdx), component l
**BROWSER**: Sometimes a component will be first mounted/rendered in the browser, for example when the user SPA navigates to a new page, or a "modal" component first appears in the page. In that case, the lifecycle will run like this:

```bash /useTask$/#d /RENDER/#b /useVisibleTask$/#c
```bash
useTask$ --> RENDER --> useVisibleTask$

| -------------- BROWSER --------------- |
Expand All @@ -83,7 +83,7 @@ Additionally, this task can be reactive and will re-execute when **tracked** [st

**Notice that any subsequent re-execution of the task will always happen in the browser**, because reactivity is a browser-only thing.

```bash /useTask$(track)/#d /RENDER/#b /CLICK/#a
```bash
(state change) -> (re-execute)
^ |
| v
Expand Down
4 changes: 3 additions & 1 deletion packages/docs/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,9 @@ export default defineConfig(async () => {
},
onVisitHighlightedLine(node: any) {
// Each line node by default has `class="line"`.
node.properties.className.push('line--highlighted');
if (node.properties.className) {
node.properties.className.push('line--highlighted');
}
},
onVisitHighlightedWord(node: any, id: string) {
// Each word node has no className by default.
Expand Down
26 changes: 24 additions & 2 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 115cc7d

Please sign in to comment.