Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OAuth Login #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add OAuth Login #107

wants to merge 1 commit into from

Conversation

xtrsyz
Copy link
Contributor

@xtrsyz xtrsyz commented Aug 2, 2023

Add login with Google

How to test on localhost

  1. Checkout to the branch
$ git fetch origin
$ git checkout oauth-login
  1. Add google auth on .env
GOOGLE_CLIENT_ID=607000444754-b26atnbkk45cuk6mvo20josc5gin504h.apps.googleusercontent.com
GOOGLE_CLIENT_SECRET=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
GOOGLE_REDIRECT_URL=http://lvh.me:8000/auth/google/callback
  1. Install requirement
composer install
  1. Run local server
$ php artisan serve
  1. Open the web http://lvh.me:8000/login

if you get error SSL certificate problem: unable to get local issuer follow this step https://stackoverflow.com/questions/29822686/curl-error-60-ssl-certificate-unable-to-get-local-issuer-certificate

@nafiesl
Copy link
Owner

nafiesl commented Aug 2, 2023

Gimana cara nge-test di localhostnya ini mas @xtrsyz?
Ini implementasi dari issue #103?

@xtrsyz
Copy link
Contributor Author

xtrsyz commented Aug 3, 2023

bisa dengan menambahkan
127.0.0.1 namadomain.com
di file /etc/hosts atau C:\Windows\System32\drivers\etc\hosts

untuk mempermudah bisa gunakan domain localhost.gigne.net yang sudah saya arahkan ke localhost 127.0.0.1

iya ini implementasi dari issue #103
image

untuk mendapatkan client_id bisa lihat ini
Google
Facebook
GitHub

@nafiesl
Copy link
Owner

nafiesl commented Aug 3, 2023

mas @xtrsyz link videmonya error sih mas (screenshot di bawah).

Kalau bisa mas kasih instruksi "how to test" step-by-stenya di deskripsi PR. Ini contoh PR yang mempermudah reviewer (repo yang lain):

Referensi bacaan:

Error link vimeo
screen_2023-08-03_005

@xtrsyz
Copy link
Contributor Author

xtrsyz commented Aug 3, 2023

link sudah saya ganti menggunakan youtube.
sudah saya sediakan domain localhost juga.

untuk referensi menggunakan localhost ada di

@xtrsyz
Copy link
Contributor Author

xtrsyz commented Aug 4, 2023

baru saya coba di localhost, ternyata ada beberapa masalah.
sudah saya buatkan step untuk mencobanya, termasuk saya berikan client_id untuk mempermudah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants