Skip to content

Commit

Permalink
Revert "Add helpful message about pooled classes"
Browse files Browse the repository at this point in the history
This reverts commit e65f17b. This might have a perf impact so we're not going to go with it for now.
  • Loading branch information
sophiebits committed Jul 11, 2014
1 parent 4526f62 commit 92d2dcc
Showing 1 changed file with 12 additions and 29 deletions.
41 changes: 12 additions & 29 deletions src/utils/PooledClass.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,6 @@

var invariant = require('invariant');

var ABOUT_POOLING_MESSAGE = null;
if (__DEV__) {
ABOUT_POOLING_MESSAGE = (
'This object is reused for performance reasons. If you\'re seeing this ' +
'after logging an object, try logging individual properties.'
);
}

/**
* Static poolers. Several custom versions for each potential number of
* arguments. A completely generic pooler is easy to implement, but would
Expand All @@ -37,54 +29,46 @@ if (__DEV__) {
*/
var oneArgumentPooler = function(copyFieldsFrom) {
var Klass = this;
var instance;
if (Klass.instancePool.length) {
instance = Klass.instancePool.pop();
var instance = Klass.instancePool.pop();
Klass.call(instance, copyFieldsFrom);
return instance;
} else {
instance = new Klass(copyFieldsFrom);
return new Klass(copyFieldsFrom);
}
instance._ABOUT_POOLING = null;
return instance;
};

var twoArgumentPooler = function(a1, a2) {
var Klass = this;
var instance;
if (Klass.instancePool.length) {
instance = Klass.instancePool.pop();
var instance = Klass.instancePool.pop();
Klass.call(instance, a1, a2);
return instance;
} else {
instance = new Klass(a1, a2);
return new Klass(a1, a2);
}
instance._ABOUT_POOLING = null;
return instance;
};

var threeArgumentPooler = function(a1, a2, a3) {
var Klass = this;
var instance;
if (Klass.instancePool.length) {
instance = Klass.instancePool.pop();
var instance = Klass.instancePool.pop();
Klass.call(instance, a1, a2, a3);
return instance;
} else {
instance = new Klass(a1, a2, a3);
return new Klass(a1, a2, a3);
}
instance._ABOUT_POOLING = null;
return instance;
};

var fiveArgumentPooler = function(a1, a2, a3, a4, a5) {
var Klass = this;
var instance;
if (Klass.instancePool.length) {
instance = Klass.instancePool.pop();
var instance = Klass.instancePool.pop();
Klass.call(instance, a1, a2, a3, a4, a5);
return instance;
} else {
instance = new Klass(a1, a2, a3, a4, a5);
return new Klass(a1, a2, a3, a4, a5);
}
instance._ABOUT_POOLING = null;
return instance;
};

var standardReleaser = function(instance) {
Expand All @@ -96,7 +80,6 @@ var standardReleaser = function(instance) {
if (instance.destructor) {
instance.destructor();
}
instance._ABOUT_POOLING = ABOUT_POOLING_MESSAGE;
if (Klass.instancePool.length < Klass.poolSize) {
Klass.instancePool.push(instance);
}
Expand Down

0 comments on commit 92d2dcc

Please sign in to comment.