Add default no-op implementation to interface.

nagyist · Nov 11, 2024 · 2408f46 · 2408f46
1 parent e4ab842
commit 2408f46
Show file tree

Hide file tree

Showing 9 changed files with 4 additions and 49 deletions.
diff --git a/brick/src/main/java/ch/cyberduck/core/brick/BrickTouchFeature.java b/brick/src/main/java/ch/cyberduck/core/brick/BrickTouchFeature.java
@@ -22,7 +22,6 @@
 import ch.cyberduck.core.brick.io.swagger.client.model.FileUploadPartEntity;
 import ch.cyberduck.core.exception.BackgroundException;
 import ch.cyberduck.core.features.Touch;
-import ch.cyberduck.core.features.Write;
 import ch.cyberduck.core.transfer.TransferStatus;
 
 import java.io.IOException;
@@ -54,9 +53,4 @@ public Path touch(final Path file, final TransferStatus status) throws Backgroun
             throw new DefaultIOExceptionMappingService().map("Cannot create {0}", e, file);
         }
     }
-
-    @Override
-    public Touch<FileEntity> withWriter(final Write<FileEntity> writer) {
-        return this;
-    }
 }
diff --git a/core/src/main/java/ch/cyberduck/core/features/Touch.java b/core/src/main/java/ch/cyberduck/core/features/Touch.java
@@ -43,7 +43,9 @@ default boolean isSupported(final Path workdir, final String filename) {
         }
     }
 
-    Touch<Reply> withWriter(Write<Reply> writer);
+    default Touch<Reply> withWriter(Write<Reply> writer) {
+        return this;
+    }
 
     /**
      * @throws AccessDeniedException Permission failure for target directory

diff --git a/cryptomator/src/main/java/ch/cyberduck/core/cryptomator/features/CryptoTouchFeature.java b/cryptomator/src/main/java/ch/cyberduck/core/cryptomator/features/CryptoTouchFeature.java
@@ -70,11 +70,6 @@ public void preflight(final Path workdir, final String filename) throws Backgrou
         proxy.preflight(workdir, filename);
     }
 
-    @Override
-    public CryptoTouchFeature<Reply> withWriter(final Write<Reply> writer) {
-        return this;
-    }
-
     @Override
     public String toString() {
         final StringBuilder sb = new StringBuilder("CryptoTouchFeature{");

diff --git a/googledrive/src/main/java/ch/cyberduck/core/googledrive/DriveTouchFeature.java b/googledrive/src/main/java/ch/cyberduck/core/googledrive/DriveTouchFeature.java
@@ -24,7 +24,6 @@
 import ch.cyberduck.core.exception.ConflictException;
 import ch.cyberduck.core.exception.NotfoundException;
 import ch.cyberduck.core.features.Touch;
-import ch.cyberduck.core.features.Write;
 import ch.cyberduck.core.preferences.HostPreferences;
 import ch.cyberduck.core.transfer.TransferStatus;
 
@@ -71,11 +70,6 @@ public Path touch(final Path file, final TransferStatus status) throws Backgroun
         }
     }
 
-    @Override
-    public DriveTouchFeature withWriter(final Write<VersionId> writer) {
-        return this;
-    }
-
     @Override
     public void preflight(final Path workdir, final String filename) throws BackgroundException {
         if(workdir.isRoot()) {

diff --git a/irods/src/main/java/ch/cyberduck/core/irods/IRODSTouchFeature.java b/irods/src/main/java/ch/cyberduck/core/irods/IRODSTouchFeature.java
@@ -20,7 +20,6 @@
 import ch.cyberduck.core.Path;
 import ch.cyberduck.core.exception.BackgroundException;
 import ch.cyberduck.core.features.Touch;
-import ch.cyberduck.core.features.Write;
 import ch.cyberduck.core.transfer.TransferStatus;
 
 import org.irods.jargon.core.exception.JargonException;
@@ -40,17 +39,12 @@ public Path touch(final Path file, final TransferStatus status) throws Backgroun
         try {
             final IRODSFileSystemAO fs = session.getClient();
             final int descriptor = fs.createFile(file.getAbsolute(),
-                DataObjInp.OpenFlags.WRITE_TRUNCATE, DataObjInp.DEFAULT_CREATE_MODE);
+                    DataObjInp.OpenFlags.WRITE_TRUNCATE, DataObjInp.DEFAULT_CREATE_MODE);
             fs.fileClose(descriptor, false);
             return file;
         }
         catch(JargonException e) {
             throw new IRODSExceptionMappingService().map("Cannot create {0}", e, file);
         }
     }
-
-    @Override
-    public Touch withWriter(final Write writer) {
-        return this;
-    }
 }
diff --git a/manta/src/main/java/ch/cyberduck/core/manta/MantaTouchFeature.java b/manta/src/main/java/ch/cyberduck/core/manta/MantaTouchFeature.java
@@ -21,7 +21,6 @@
 import ch.cyberduck.core.exception.AccessDeniedException;
 import ch.cyberduck.core.exception.BackgroundException;
 import ch.cyberduck.core.features.Touch;
-import ch.cyberduck.core.features.Write;
 import ch.cyberduck.core.transfer.TransferStatus;
 
 import java.io.IOException;
@@ -65,9 +64,4 @@ public void preflight(final Path workdir, final String filename) throws Backgrou
             throw new AccessDeniedException(MessageFormat.format(LocaleFactory.localizedString("Cannot create {0}", "Error"), filename)).withFile(workdir);
         }
     }
-
-    @Override
-    public Touch withWriter(final Write writer) {
-        return this;
-    }
 }
diff --git a/nio/src/main/java/ch/cyberduck/core/nio/LocalTouchFeature.java b/nio/src/main/java/ch/cyberduck/core/nio/LocalTouchFeature.java
@@ -17,7 +17,6 @@
 import ch.cyberduck.core.Path;
 import ch.cyberduck.core.exception.BackgroundException;
 import ch.cyberduck.core.features.Touch;
-import ch.cyberduck.core.features.Write;
 import ch.cyberduck.core.transfer.TransferStatus;
 
 import java.io.IOException;
@@ -47,10 +46,5 @@ public Path touch(final Path file, final TransferStatus status) throws Backgroun
         }
         return file;
     }
-
-    @Override
-    public Touch withWriter(final Write writer) {
-        return this;
-    }
 }
 
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphTouchFeature.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphTouchFeature.java
@@ -24,7 +24,6 @@
 import ch.cyberduck.core.exception.AccessDeniedException;
 import ch.cyberduck.core.exception.BackgroundException;
 import ch.cyberduck.core.features.Touch;
-import ch.cyberduck.core.features.Write;
 import ch.cyberduck.core.onedrive.GraphExceptionMappingService;
 import ch.cyberduck.core.onedrive.GraphSession;
 import ch.cyberduck.core.transfer.TransferStatus;
@@ -71,9 +70,4 @@ public void preflight(final Path workdir, final String filename) throws Backgrou
             throw new AccessDeniedException(MessageFormat.format(LocaleFactory.localizedString("Cannot create {0}", "Error"), filename)).withFile(workdir);
         }
     }
-
-    @Override
-    public Touch<DriveItem.Metadata> withWriter(final Write writer) {
-        return this;
-    }
 }
diff --git a/ssh/src/main/java/ch/cyberduck/core/sftp/SFTPTouchFeature.java b/ssh/src/main/java/ch/cyberduck/core/sftp/SFTPTouchFeature.java
@@ -21,7 +21,6 @@
 import ch.cyberduck.core.Permission;
 import ch.cyberduck.core.exception.BackgroundException;
 import ch.cyberduck.core.features.Touch;
-import ch.cyberduck.core.features.Write;
 import ch.cyberduck.core.transfer.TransferStatus;
 
 import java.io.IOException;
@@ -58,9 +57,4 @@ public Path touch(final Path file, final TransferStatus status) throws Backgroun
         }
         return file;
     }
-
-    @Override
-    public SFTPTouchFeature withWriter(final Write writer) {
-        return this;
-    }
 }